From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26819C433E0 for ; Wed, 3 Mar 2021 23:24:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9394664F0D for ; Wed, 3 Mar 2021 23:24:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9394664F0D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ECA886B0006; Wed, 3 Mar 2021 18:23:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E75366B0007; Wed, 3 Mar 2021 18:23:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1AF16B0008; Wed, 3 Mar 2021 18:23:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 9A60D6B0006 for ; Wed, 3 Mar 2021 18:23:58 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 62CAB513 for ; Wed, 3 Mar 2021 23:23:58 +0000 (UTC) X-FDA: 77880142956.11.E48D422 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP id 9ED0E139 for ; Wed, 3 Mar 2021 23:23:56 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 145A760233; Wed, 3 Mar 2021 23:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614813836; bh=YMSyNa4++ljWmknoCKqH6X9s0lAu4Qvhp/VPJBvZ/dk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2nTUbnis/jdNQaDkSQgZIYAczNTMtqPS9fU4RVMq4V6MfaZeLTm8Y8MOig85f7cIY /k7rfMBnm65kI3AmI5UDMW7SPPtpJjFszoqQ28M1KX+BqCBTYQYwteMAnGQb7WdiNf HVGLEW4b7li43GsVGKhc1UMzFoZ9IvGEG6IT+iqc= Date: Wed, 3 Mar 2021 15:23:55 -0800 From: Andrew Morton To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kasan, mm: fix crash with HW_TAGS and DEBUG_PAGEALLOC Message-Id: <20210303152355.fa7c3bcb02862ceefea5ca45@linux-foundation.org> In-Reply-To: <1aa83e48627978de8068d5e3314185f3a0d7a849.1614302398.git.andreyknvl@google.com> References: <1aa83e48627978de8068d5e3314185f3a0d7a849.1614302398.git.andreyknvl@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: xo4i3ac413bg37f4a4esm9jb3n9r89z8 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9ED0E139 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614813836-19201 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 26 Feb 2021 02:25:37 +0100 Andrey Konovalov wrote: > Currently, kasan_free_nondeferred_pages()->kasan_free_pages() is called > after debug_pagealloc_unmap_pages(). This causes a crash when > debug_pagealloc is enabled, as HW_TAGS KASAN can't set tags on an > unmapped page. > > This patch puts kasan_free_nondeferred_pages() before > debug_pagealloc_unmap_pages(). > > Besides fixing the crash, this also makes the annotation order consistent > with debug_pagealloc_map_pages() preceding kasan_alloc_pages(). > This bug exists in 5.12, does it not? If so, is cc:stable appropriate and if so, do we have a suitable Fixes: commit? Thanks.