From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 933F8C433DB for ; Wed, 3 Mar 2021 10:19:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E35864EDF for ; Wed, 3 Mar 2021 10:19:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E35864EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 654A98D0143; Wed, 3 Mar 2021 05:19:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 604B48D0135; Wed, 3 Mar 2021 05:19:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CC298D0143; Wed, 3 Mar 2021 05:19:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 32A228D0135 for ; Wed, 3 Mar 2021 05:19:34 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CF7EA8157 for ; Wed, 3 Mar 2021 10:19:33 +0000 (UTC) X-FDA: 77878166226.13.3E00A96 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 9F973C0007CB for ; Wed, 3 Mar 2021 10:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614766772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lVfA4qsQ/EcXcCKiEC4CuqfV0xUeTJfshoPATWapESA=; b=InmdwqdRS6Q9PtVjzk3EPgSVha1/xzV699YuwbXfYn0QWP7EJgDSnnutrCIgJz37wdHC5m gapa8aUP7GW/iEs6qh0iL1NdzdnYT8Fiqi+5R+itpU9yrPZdhqamzJZUriS7Ftdy2ccVfg jbfJcFP1dj26Sh5hkMH8PyQL9JEl1Eo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-hoiVQ_PyMYyo5ByJpG6gZA-1; Wed, 03 Mar 2021 05:19:28 -0500 X-MC-Unique: hoiVQ_PyMYyo5ByJpG6gZA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1DA6835E20; Wed, 3 Mar 2021 10:19:26 +0000 (UTC) Received: from carbon (unknown [10.36.110.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id ACB3B60BFA; Wed, 3 Mar 2021 10:19:20 +0000 (UTC) Date: Wed, 3 Mar 2021 11:19:19 +0100 From: Jesper Dangaard Brouer To: Mel Gorman Cc: Ilias Apalodimas , Andrew Morton , Chuck Lever , LKML , Linux-Net , Linux-MM , Linux-NFS , brouer@redhat.com Subject: Re: [PATCH 4/5] net: page_pool: refactor dma_map into own function page_pool_dma_map Message-ID: <20210303111919.3c6e29cc@carbon> In-Reply-To: <20210303091825.GO3697@techsingularity.net> References: <20210301161200.18852-1-mgorman@techsingularity.net> <20210301161200.18852-5-mgorman@techsingularity.net> <20210303091825.GO3697@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Stat-Signature: 9533w5kjm41p9pey65p5fnsd9ixc3edo X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9F973C0007CB Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614766771-380861 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 3 Mar 2021 09:18:25 +0000 Mel Gorman wrote: > On Tue, Mar 02, 2021 at 08:49:06PM +0200, Ilias Apalodimas wrote: > > On Mon, Mar 01, 2021 at 04:11:59PM +0000, Mel Gorman wrote: > > > From: Jesper Dangaard Brouer > > > > > > In preparation for next patch, move the dma mapping into its own > > > function, as this will make it easier to follow the changes. > > > > > > V2: make page_pool_dma_map return boolean (Ilias) > > > > > > > [...] > > > > > @@ -211,30 +234,14 @@ static struct page *__page_pool_alloc_pages_slow(struct page_pool *pool, > > > if (!page) > > > return NULL; > > > > > > - if (!(pool->p.flags & PP_FLAG_DMA_MAP)) > > > - goto skip_dma_map; > > > - > > > - /* Setup DMA mapping: use 'struct page' area for storing DMA-addr > > > - * since dma_addr_t can be either 32 or 64 bits and does not always fit > > > - * into page private data (i.e 32bit cpu with 64bit DMA caps) > > > - * This mapping is kept for lifetime of page, until leaving pool. > > > - */ > > > - dma = dma_map_page_attrs(pool->p.dev, page, 0, > > > - (PAGE_SIZE << pool->p.order), > > > - pool->p.dma_dir, DMA_ATTR_SKIP_CPU_SYNC); > > > - if (dma_mapping_error(pool->p.dev, dma)) { > > > + if (pp_flags & PP_FLAG_DMA_MAP && > > > > Nit pick but can we have if ((pp_flags & PP_FLAG_DMA_MAP) && ... > > > > Done. Thanks for fixing this nitpick, and carrying the patch. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer