From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC66C433DB for ; Wed, 3 Mar 2021 07:16:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DF3E64EBD for ; Wed, 3 Mar 2021 07:16:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DF3E64EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 84B7B8D012F; Wed, 3 Mar 2021 02:16:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FA078D0127; Wed, 3 Mar 2021 02:16:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69BC68D012F; Wed, 3 Mar 2021 02:16:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 4EF388D0127 for ; Wed, 3 Mar 2021 02:16:14 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0ACA73632 for ; Wed, 3 Mar 2021 07:16:14 +0000 (UTC) X-FDA: 77877704268.27.865BC20 Received: from mail-qk1-f201.google.com (mail-qk1-f201.google.com [209.85.222.201]) by imf30.hostedemail.com (Postfix) with ESMTP id 45A7BE0011C5 for ; Wed, 3 Mar 2021 07:16:12 +0000 (UTC) Received: by mail-qk1-f201.google.com with SMTP id g18so9061388qki.15 for ; Tue, 02 Mar 2021 23:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=Mnua9sIpK4opv1bat3S4YMVM0wLz7zG7EDFUzDE8sqE=; b=hrT1ZnLtQU+yhwzRAN83U2EvzE0FXH5gAcsU/4kIr7dt6WlCWitE6Zo4dcHWpT/xfN S8Bksk5PZK8jeiXjD3s91Eplec/+1eTPJGl5rTAqIP5GwQhD7rkPpSDBNy+UEBF+GySd yCQK23q5uHZGpA+bBUBVNvdpdbPfjlK/dAwuAZbwJIikjS6GuWDXmi8wpp/tPT/etAoE b+A8MIprP6qE2T5WH+CIedjotGXMb8fopDkdIz/3vVqc2Eq5EGdfaiiP7woksQ3PNuiy PU0A2wwI+DE+6DCtmliZw9cDO+GMbnlHE1ymcc9olNm474R/F45cdVnbVOLwlAEy37UL nNrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=Mnua9sIpK4opv1bat3S4YMVM0wLz7zG7EDFUzDE8sqE=; b=X5jHL9Y4hQjXLpnW3hVEKOPi/QJF39zeLoDYHJPPPPljjtum0gQlkR+cbz+LAP9p01 sGqxoc4QUxSagFiqHyVE0ouQoK4EnzRYtH51KCq6KYHgczQkLzGoxaAeHe1OCxEGmXzj snxhMKOjN784sT2Qwf6vHdsE0uknoNx9DtlfSZCJMbZArGKfC4pYD25qjmA4aJPKHChK pPL7+qQZs5oYTHWIL95/h1pL+gn1bfGqBBQW/5+bCuuL694+MDo+t+gFJxJKjE3Lo1FH AJlrjhz+t1zlp6l1gYW3EtvrnPzsNYud7jr/pEXuGDnCpX6z/axGXvCVbr6vxtKUtenI uBJQ== X-Gm-Message-State: AOAM531pQXLl9zo4MkNyKiKDnmnfGw+D16g5jcm0KzfchbTrLpEXfcbR jmlZ+N87Rm5mwpgeeDRVPJ/cnVEHp5o= X-Google-Smtp-Source: ABdhPJyGSB4z+pduFim01lG0Bb1doDwpJf2J5Ka4e2MdOhYE45ZwWhwKA0kUzFI/+t2Id2aBe4JXpHo/vKI= X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:4877:a627:46e9:4b6]) (user=yuzhao job=sendgmr) by 2002:a0c:e84d:: with SMTP id l13mr7151041qvo.28.1614755772802; Tue, 02 Mar 2021 23:16:12 -0800 (PST) Date: Wed, 3 Mar 2021 00:16:08 -0700 Message-Id: <20210303071609.797782-1-yuzhao@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.30.1.766.gb4fecdf3b7-goog Subject: [PATCH 1/2] mm: correctly determine LAST_CPUPID_WIDTH From: Yu Zhao To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yu Zhao Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: xzt94npge78r3wacoakidk8iordw4mxb X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 45A7BE0011C5 Received-SPF: none (flex--yuzhao.bounces.google.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from="<3vDc_YAYKCDElhmUNbTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yuzhao.bounces.google.com>"; helo=mail-qk1-f201.google.com; client-ip=209.85.222.201 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614755772-492857 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The naming convention used in include/linux/page-flags-layout.h: *_SHIFT: the number of bits trying to allocate *_WIDTH: the number of bits successfully allocated So when it comes to LAST_CPUPID_WIDTH, we need to check whether all previous *_WIDTH and LAST_CPUPID_SHIFT can fit into page flags. This means we need to use NODES_WIDTH, not NODES_SHIFT. Signed-off-by: Yu Zhao --- include/linux/page-flags-layout.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/page-flags-layout.h b/include/linux/page-flags-layout.h index 7d4ec26d8a3e..295c2c687d2c 100644 --- a/include/linux/page-flags-layout.h +++ b/include/linux/page-flags-layout.h @@ -83,7 +83,7 @@ #define KASAN_TAG_WIDTH 0 #endif -#if SECTIONS_WIDTH+ZONES_WIDTH+NODES_SHIFT+LAST_CPUPID_SHIFT+KASAN_TAG_WIDTH \ +#if SECTIONS_WIDTH+ZONES_WIDTH+NODES_WIDTH+LAST_CPUPID_SHIFT+KASAN_TAG_WIDTH \ <= BITS_PER_LONG - NR_PAGEFLAGS #define LAST_CPUPID_WIDTH LAST_CPUPID_SHIFT #else -- 2.30.1.766.gb4fecdf3b7-goog