From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F39FC433E0 for ; Mon, 1 Mar 2021 11:50:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0322B64E31 for ; Mon, 1 Mar 2021 11:50:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0322B64E31 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8483E6B00D5; Mon, 1 Mar 2021 06:50:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D1706B00D6; Mon, 1 Mar 2021 06:50:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6999F8D0062; Mon, 1 Mar 2021 06:50:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 4F2986B00D5 for ; Mon, 1 Mar 2021 06:50:03 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 185363649 for ; Mon, 1 Mar 2021 11:50:03 +0000 (UTC) X-FDA: 77871136686.20.0829661 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf10.hostedemail.com (Postfix) with ESMTP id EBD1E407F8F3 for ; Mon, 1 Mar 2021 11:49:55 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id n16so8069696lfb.4 for ; Mon, 01 Mar 2021 03:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3+UEhAxrb3pdEALJdsSgG5yRtHrbuB7y+oF/2tb+rtA=; b=O4xa6E4uEEU9hIiBa38slwGEphrxXrvJN4nNP7qNQl9R+N5t/ni0WCPfg9KGgv/PJS J4yoMROyYQjzho9NPt5Z875ScmJX4eIkCFOn+jGCOAAUpdSQ0gN9h79CHOsn8692dysT lVoes2J+BR3uVXXaJbapMzFRGpgZew7Je2hIRAEg0yK0NKBp0HxwcJb3BoSyUk1TLTOG yQHQZ0wqXVFRCdyjz3Dn8y0POBHrE8IWDFE0W3HtbLNj90D0m0vk+BfVQSeUl3SpBK3A tvG0P8V2cFA5/rFkEEgnC8Vu+6EFsaxuLn5Ynr88x7VC9BoPMrDoyzTn2rvNDQeIi8Zg s8AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3+UEhAxrb3pdEALJdsSgG5yRtHrbuB7y+oF/2tb+rtA=; b=o9uEVI1mHP7inDTBk+6zJQ+eJ9t0GPvNzLEmKRWpbGAZ34S4cUmQd6F+bexX3pKXaY w1JKUoml0pg54GUypukAhlmRcyLuVDSLStrgo9pMvBZLWRuTp3mowt/snfjTAzH4YRMH 1AEzYTxPMuzkSwIYmT/PO9N4o27DC6yPX8z3jxAfxdIcCbSGu32HiJzzrVlWHaK2Nc5l 34TF4lZequiEtDOq2KGZl9fzZ4WbHe+udjKAl2QvBrO+68fG102J4YsibkU/9HoqWJr9 bspJYuM3Cg8GjM66SmWpil1yt67N2SFkxYRufDJBwXmaWKmWuP44jCB0iBoyN6t5JCof QM2Q== X-Gm-Message-State: AOAM532J4cBdb4qg2Hz73mmgae+GVi14AurbWleP2BMgctPQFGbUubmg O7a9qhjPcJMbqCg82WGBl6zaDQ== X-Google-Smtp-Source: ABdhPJwh6c5qWPWg0F37ArphLQNHvLT3R9XMEvHVo+ZAItUpRqW7U1KzTIwnIJVSqj/jCJoTgiIE7A== X-Received: by 2002:ac2:42cc:: with SMTP id n12mr8975485lfl.560.1614599400869; Mon, 01 Mar 2021 03:50:00 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id z28sm1541471ljn.117.2021.03.01.03.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 03:50:00 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 3DC06102557; Mon, 1 Mar 2021 14:50:07 +0300 (+03) Date: Mon, 1 Mar 2021 14:50:07 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: Yu Zhao , akpm@linux-foundation.org, alex.shi@linux.alibaba.com, vbabka@suse.cz, guro@fb.com, hannes@cmpxchg.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, vdavydov.dev@gmail.com Subject: Re: [PATCH v2 3/3] mm: use PF_ONLY_HEAD for PG_active and PG_unevictable Message-ID: <20210301115007.mgw5vthgjoibnjf4@box> References: <20210224084807.2179942-1-yuzhao@google.com> <20210226091718.2927291-1-yuzhao@google.com> <20210226091718.2927291-4-yuzhao@google.com> <20210226121314.GB2723601@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226121314.GB2723601@casper.infradead.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EBD1E407F8F3 X-Stat-Signature: oika1ey6kjh3xjeyn974n9g4x6nppstb Received-SPF: none (shutemov.name>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-lf1-f52.google.com; client-ip=209.85.167.52 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614599395-186538 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 26, 2021 at 12:13:14PM +0000, Matthew Wilcox wrote: > On Fri, Feb 26, 2021 at 02:17:18AM -0700, Yu Zhao wrote: > > All places but one test, set or clear PG_active and PG_unevictable on > > small or head pages. Use compound_head() explicitly for that singleton > > so the rest can rid of redundant compound_head(). > > How do you know it's only one place? I really wish you'd work with me > on folios. They make the compiler prove that it's not a tail page. +1 to this. The problem with compound_head() is systemic and ad-hoc solution to few page flags will only complicate the picture. -- Kirill A. Shutemov