From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Peter Zijlstra <peterz@infradead.org>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-mm@kvack.org
Subject: Re: add remap_pfn_range_notrack instead of reinventing it in i915
Date: Mon, 1 Mar 2021 09:45:59 +0100 [thread overview]
Message-ID: <20210301084559.GA29133@lst.de> (raw)
In-Reply-To: <YDypXb3M1uVBxcyH@phenom.ffwll.local>
On Mon, Mar 01, 2021 at 09:44:13AM +0100, Daniel Vetter wrote:
> On Mon, Mar 01, 2021 at 09:33:18AM +0100, Christoph Hellwig wrote:
> > Hi all,
> >
> > i915 has some reason to want to avoid the track_pfn_remap overhead in
> > remap_pfn_range. Add a function to the core VM to do just that rather
> > than reinventing the functionality poorly in the driver.
>
> It's not _notrack it's "rely on the tracking established by the struct
> io_mapping". Exporting a _notrack version to drivers sounds like not
> something we want to ever do. So I think you want a helper which takes the
> io_mapping, and not something that encourages drivers to go full stupid.
As far as I can tell there is no struct io_mapping anywhere near
remap_io_sg.
next prev parent reply other threads:[~2021-03-01 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 8:33 Christoph Hellwig
2021-03-01 8:33 ` [PATCH 1/2] mm: add remap_pfn_range_notrack Christoph Hellwig
2021-03-01 8:33 ` [PATCH 2/2] i915: use remap_pfn_range_notrack Christoph Hellwig
2021-03-01 8:44 ` add remap_pfn_range_notrack instead of reinventing it in i915 Daniel Vetter
2021-03-01 8:45 ` Christoph Hellwig [this message]
2021-03-01 9:13 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301084559.GA29133@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox