From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82587C433DB for ; Mon, 1 Mar 2021 07:53:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 02ACF64E3F for ; Mon, 1 Mar 2021 07:53:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02ACF64E3F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 622368D0049; Mon, 1 Mar 2021 02:53:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D3A88D0019; Mon, 1 Mar 2021 02:53:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C1308D0049; Mon, 1 Mar 2021 02:53:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 355FD8D0019 for ; Mon, 1 Mar 2021 02:53:57 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DB9143CE9 for ; Mon, 1 Mar 2021 07:53:56 +0000 (UTC) X-FDA: 77870541672.17.9B07B9B Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP id 1C25412E for ; Mon, 1 Mar 2021 07:53:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 1CE7E68BEB; Mon, 1 Mar 2021 08:53:53 +0100 (CET) Date: Mon, 1 Mar 2021 08:53:52 +0100 From: Christoph Hellwig To: Anshuman Khandual Cc: Christoph Hellwig , linux-mm@kvack.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE Message-ID: <20210301075352.GA27659@lst.de> References: <1614577853-7452-1-git-send-email-anshuman.khandual@arm.com> <20210301062358.GA25761@lst.de> <89f2d77c-f4bc-8f7b-a6b0-1c04e422fb77@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89f2d77c-f4bc-8f7b-a6b0-1c04e422fb77@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: h5me1ps1ps81pqq56o4xft4ac38atehq X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1C25412E Received-SPF: none (lst.de>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=verein.lst.de; client-ip=213.95.11.211 X-HE-DKIM-Result: none/none X-HE-Tag: 1614585228-554932 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 01, 2021 at 01:13:41PM +0530, Anshuman Khandual wrote: > > doesn't this need a 'if HUGETLB_PAGE' > > While making HUGETLB_PAGE_SIZE_VARIABLE a generic option, also made it > dependent on HUGETLB_PAGE. Should not that gate HUGETLB_PAGE_SIZE_VARIABLE > when HUGETLB_PAGE is not available irrespective of the select statement on > the platforms ? depends doesn't properly work for variables that are selected.