From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C19BEC433E0 for ; Fri, 26 Feb 2021 12:13:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4348864E38 for ; Fri, 26 Feb 2021 12:13:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4348864E38 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A3D4A6B0070; Fri, 26 Feb 2021 07:13:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ED916B0072; Fri, 26 Feb 2021 07:13:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9028C8D0001; Fri, 26 Feb 2021 07:13:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 76A6A6B0070 for ; Fri, 26 Feb 2021 07:13:44 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3A56B180238DF for ; Fri, 26 Feb 2021 12:13:44 +0000 (UTC) X-FDA: 77860309968.07.5B1E39B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 17A3680192E9 for ; Fri, 26 Feb 2021 12:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W+BHG2rTIxJEd48HjrwhvEiIlo5wfdJwA+Qad46qFNo=; b=Yqx4Zk38X8po2iPpxD21IYnw5q JiwCQiOlnWy8V33H9DnKo8WMuIGJuPGf/KJQ1n6K09aRWsQdsW2CRKebm89xlHrTi8wy5aJa16pj7 +yUhqvwa/J7HaO72DH6Y/4q+85xGe3TzjDyreMA2joUFI7fXuLN9lqBa0AYJV58U5u6gjdfWBb0VP 37nnyUaGwARo1F8zLA9lwoJZ48SjcNQ89uCRKp8Qgqq2qspncObQsdU48NPFsDqSGc38K2Kq4QRMK 84N3/UqkR7UwoRmJ06j0A6NLbNKp3M397qwZb2mLAqCD1noaUL3pTG1PUb2Az63fwJrC/B4G+DBHF lQ2Q9W5g==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lFbze-00By35-2u; Fri, 26 Feb 2021 12:13:15 +0000 Date: Fri, 26 Feb 2021 12:13:14 +0000 From: Matthew Wilcox To: Yu Zhao Cc: akpm@linux-foundation.org, alex.shi@linux.alibaba.com, vbabka@suse.cz, guro@fb.com, hannes@cmpxchg.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, vdavydov.dev@gmail.com Subject: Re: [PATCH v2 3/3] mm: use PF_ONLY_HEAD for PG_active and PG_unevictable Message-ID: <20210226121314.GB2723601@casper.infradead.org> References: <20210224084807.2179942-1-yuzhao@google.com> <20210226091718.2927291-1-yuzhao@google.com> <20210226091718.2927291-4-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226091718.2927291-4-yuzhao@google.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 17A3680192E9 X-Stat-Signature: cttrmr9xx3urk7bpct15tpu9id9adyug Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614341622-283445 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 26, 2021 at 02:17:18AM -0700, Yu Zhao wrote: > All places but one test, set or clear PG_active and PG_unevictable on > small or head pages. Use compound_head() explicitly for that singleton > so the rest can rid of redundant compound_head(). How do you know it's only one place? I really wish you'd work with me on folios. They make the compiler prove that it's not a tail page.