From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B18C3C433DB for ; Fri, 26 Feb 2021 10:59:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3183964EE7 for ; Fri, 26 Feb 2021 10:59:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3183964EE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F03A6B0005; Fri, 26 Feb 2021 05:59:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A09A6B0006; Fri, 26 Feb 2021 05:59:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88F0A6B006C; Fri, 26 Feb 2021 05:59:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 741BD6B0005 for ; Fri, 26 Feb 2021 05:59:24 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 39F07BBD1 for ; Fri, 26 Feb 2021 10:59:24 +0000 (UTC) X-FDA: 77860122648.17.716697E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf10.hostedemail.com (Postfix) with ESMTP id DB4BA4080F48 for ; Fri, 26 Feb 2021 10:59:17 +0000 (UTC) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11QAYtWN131166; Fri, 26 Feb 2021 05:59:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=00s2MsyW/a2AE1oZWb1iglLJz/LlWkEfj9iznPhKodI=; b=bseSV9G2g5lxLnBShjcXJu/ZNxJuc2/iqsRHGhZeLxB/bwhXzvUmrJXxdQkJnRiIUo1i TX2cwgiPQfK4AyUJmWIG5zmIgData+5xUuAAIXcrrh/77Rse5nEmkczvLVPh8FIqQ54h udRtO13yMzwUeOnWLw2/qMR596vqi97GoCjd7yVRdGOwYUNPT6cpFVI/KyYF8u1Q02W+ upR8eLGLcnk7ccYzL3UtteSgJYDo6a6q2iDKNIXl2UxCrWIKx8zTUvflWU2uP6UrYw+n TnQgllGRjHTJn5eaRlDwFIrsT98Wf9R01cmEAJW4BGU2gMWQYa7IqzJWzeU+jAOH9uhq ug== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 36xjs1bu2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Feb 2021 05:59:10 -0500 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 11QAgGew169368; Fri, 26 Feb 2021 05:59:09 -0500 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 36xjs1bu1j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Feb 2021 05:59:09 -0500 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11QAw117007075; Fri, 26 Feb 2021 10:59:07 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03fra.de.ibm.com with ESMTP id 36tt28trc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Feb 2021 10:59:06 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11QAx45V41419216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Feb 2021 10:59:04 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6CBA5A4065; Fri, 26 Feb 2021 10:59:04 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 415A5A4040; Fri, 26 Feb 2021 10:59:02 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.51.238]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 26 Feb 2021 10:59:02 +0000 (GMT) Date: Fri, 26 Feb 2021 12:59:00 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: Mike Rapoport , Andrew Morton , Andrea Arcangeli , Baoquan He , Borislav Petkov , Chris Wilson , David Hildenbrand , "H. Peter Anvin" , Ingo Molnar , Linus Torvalds , =?utf-8?Q?=C5=81ukasz?= Majczak , Mel Gorman , Michal Hocko , Qian Cai , "Sarvela, Tomi P" , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v7 1/1] mm/page_alloc.c: refactor initialization of struct page for holes in memory layout Message-ID: <20210226105900.GK1854360@linux.ibm.com> References: <20210224153950.20789-1-rppt@kernel.org> <20210224153950.20789-2-rppt@kernel.org> <20210225180521.GH1854360@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-26_02:2021-02-24,2021-02-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102260082 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DB4BA4080F48 X-Stat-Signature: hj1kzi13adeyybuipsnuwq6fjjmeoezz Received-SPF: none (linux.ibm.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mx0a-001b2d01.pphosted.com; client-ip=148.163.156.1 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614337157-85448 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 25, 2021 at 07:38:44PM +0100, Vlastimil Babka wrote: > On 2/25/21 7:05 PM, Mike Rapoport wrote: > >> > >> What if two zones are adjacent? I.e. if the hole was at a boundary between two > >> zones. > > > > What do you mean by "adjacent zones"? If there is a hole near the zone > > boundary, zone span would be clamped to exclude the hole. > > Yeah, zone span should exclude those pages, but you still somehow handle them? > That's how I read "pages that are not spanned by any node will get links to the > adjacent zone/node." > So is it always a unique zone/node can be determined? > > Let's say we have: > > > ---- pageblock boundary ---- > > > > ---- pageblock boundary ---- > > Now I hope such configurations don't really exist :) But if we simulated them in > QEMU, what would be the linkage in struct pages in that hole? I don't think such configuration is possible in practice but it can be forced with e.g memmap="2M hole at 4G - 1M". The hole in your example the hole will get node1 for node and zone that spans the beginning of node1 for zone. -- Sincerely yours, Mike.