From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B7AC433DB for ; Fri, 26 Feb 2021 06:15:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E517164EE2 for ; Fri, 26 Feb 2021 06:15:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E517164EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 29EEC6B0005; Fri, 26 Feb 2021 01:15:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 227ED6B0006; Fri, 26 Feb 2021 01:15:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F11F6B006C; Fri, 26 Feb 2021 01:15:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id E8FDF6B0005 for ; Fri, 26 Feb 2021 01:15:01 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 988528248068 for ; Fri, 26 Feb 2021 06:15:01 +0000 (UTC) X-FDA: 77859406002.18.BA9BCF3 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP id C125AC0007C7 for ; Fri, 26 Feb 2021 06:14:57 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 182F064ECE; Fri, 26 Feb 2021 06:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614320099; bh=upBgsw9MrC0lpO/fX8N9W+GusLFFDVXbTMTqwXQG7LI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SNMk5g0Q22g4zX8EMpa2/MOBPbFUHtr7OTVjWUFzzgJlURL8Lq6mjJlZUc7S9wJEV ptmDv9LycWfr4H8HgKpnS3cJzQcKIPVd7cmbRGeE6F9hJq1JMXfkBqxAEZXRLT+jDo OSKaSc4DxIIqGoBMMaAG2Ymmcc7ESmJeaub7nnuh9sS1i0wqA9PWJxjz4x4o490TFE Zko74uAvBQOhH8P8xjTlXGL821K1cNYLSx5CVeUCVAWpe4wncHkZKvCwrhLEILAW+N m9Hz1RjZhtj84dlzYFhUs1lIxbO4KbnHSA8WaZG0mvEIiGT+Un5R+LRtLH5u1f90gr v/iV2CQ2GJLRg== Date: Fri, 26 Feb 2021 08:14:47 +0200 From: Mike Rapoport To: Andrew Morton Cc: Andrea Arcangeli , Baoquan He , Borislav Petkov , Chris Wilson , David Hildenbrand , "H. Peter Anvin" , Ingo Molnar , Linus Torvalds , =?utf-8?Q?=C5=81ukasz?= Majczak , Mel Gorman , Michal Hocko , Mike Rapoport , Qian Cai , "Sarvela, Tomi P" , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v8 1/1] mm/page_alloc.c: refactor initialization of struct page for holes in memory layout Message-ID: <20210226061447.GN1447004@kernel.org> References: <20210225224351.7356-1-rppt@kernel.org> <20210225224351.7356-2-rppt@kernel.org> <20210225160851.43b50f0d02f8da958a2b7887@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225160851.43b50f0d02f8da958a2b7887@linux-foundation.org> X-Stat-Signature: hg3f7k7i1719cd6mn9ks4xmgo3hcang8 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C125AC0007C7 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614320097-322954 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 25, 2021 at 04:08:51PM -0800, Andrew Morton wrote: > On Fri, 26 Feb 2021 00:43:51 +0200 Mike Rapoport wrote: > > > From: Mike Rapoport > > > void __meminit __weak memmap_init_zone(struct zone *zone) > > { > > unsigned long zone_start_pfn = zone->zone_start_pfn; > > unsigned long zone_end_pfn = zone_start_pfn + zone->spanned_pages; > > int i, nid = zone_to_nid(zone), zone_id = zone_idx(zone); > > + static unsigned long hole_pfn = 0; > > static implies that pgdat->node_zones[] is alwyas sorted in ascending > pfn order. Always true? Yes. -- Sincerely yours, Mike.