From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BFC3C433E0 for ; Wed, 24 Feb 2021 20:05:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFBC664E20 for ; Wed, 24 Feb 2021 20:05:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFBC664E20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B4FC6B00AF; Wed, 24 Feb 2021 15:05:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68E038D0014; Wed, 24 Feb 2021 15:05:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A4D68D000B; Wed, 24 Feb 2021 15:05:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 4576F6B00AF for ; Wed, 24 Feb 2021 15:05:04 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 169281730876 for ; Wed, 24 Feb 2021 20:05:04 +0000 (UTC) X-FDA: 77854240128.02.D2F5338 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP id 1DB17407F8DC for ; Wed, 24 Feb 2021 20:04:50 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 15D7F64F20; Wed, 24 Feb 2021 20:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614197102; bh=vFh4qvEWMqr1XNAa0CR0/f9E19one+5mBlwsfnK63do=; h=Date:From:To:Subject:In-Reply-To:From; b=meL1AX21BoUYPv4qlKtSqm6odGKPfuEoD82MDU2TScTniGMZwOr0pcsbPO237E+d5 iq1ur6bK0JZRaeMauMQsK/WRfqXyV28JeKKfqPIL5oXDZKPRL++LHVDOzz2CKZn3H/ KS9feUiChP4IAVZbnqA2JgCKXc6s7/AeglK5esw4= Date: Wed, 24 Feb 2021 12:05:00 -0800 From: Andrew Morton To: abaci-bugfix@linux.alibaba.com, abaci@linux.alibaba.com, adobriyan@gmail.com, akpm@linux-foundation.org, bhe@redhat.com, dyoung@redhat.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, urezki@gmail.com, vgoyal@redhat.com Subject: [patch 085/173] vmalloc: remove redundant NULL check Message-ID: <20210224200500.Nfm1N1293%akpm@linux-foundation.org> In-Reply-To: <20210224115824.1e289a6895087f10c41dd8d6@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1DB17407F8DC X-Stat-Signature: zrxbri53qeyz5qd37hp6cehsjks8p9zr Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614197090-607353 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yang Li Subject: vmalloc: remove redundant NULL check Fix below warnings reported by coccicheck: ./fs/proc/vmcore.c:1503:2-7: WARNING: NULL check before some freeing functions is not needed. Link: https://lkml.kernel.org/r/1611216753-44598-1-git-send-email-abaci-bugfix@linux.alibaba.com Signed-off-by: Yang Li Reported-by: Abaci Robot Acked-by: Baoquan He Cc: Dave Young Cc: Vivek Goyal Cc: Alexey Dobriyan Cc: "Uladzislau Rezki (Sony)" Signed-off-by: Andrew Morton --- fs/proc/vmcore.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/fs/proc/vmcore.c~vmalloc-remove-redundant-null-check +++ a/fs/proc/vmcore.c @@ -1503,11 +1503,8 @@ int vmcore_add_device_dump(struct vmcore return 0; out_err: - if (buf) - vfree(buf); - - if (dump) - vfree(dump); + vfree(buf); + vfree(dump); return ret; } _