From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA251C433DB for ; Wed, 24 Feb 2021 20:04:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 62E2E64F09 for ; Wed, 24 Feb 2021 20:04:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62E2E64F09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ECF478D0001; Wed, 24 Feb 2021 15:04:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E803A6B0099; Wed, 24 Feb 2021 15:04:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4C238D0001; Wed, 24 Feb 2021 15:04:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id BCDD06B0098 for ; Wed, 24 Feb 2021 15:04:07 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 865E9FB63 for ; Wed, 24 Feb 2021 20:04:07 +0000 (UTC) X-FDA: 77854237734.23.BEEFA4D Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf01.hostedemail.com (Postfix) with ESMTP id 75C642000382 for ; Wed, 24 Feb 2021 20:04:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CBBF264F2B; Wed, 24 Feb 2021 20:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614197046; bh=AW6VtjcalHNtIglQEhdtRWcN5XijATaQZwWBHKishGU=; h=Date:From:To:Subject:In-Reply-To:From; b=WOwYQg0f0aShgkmdreL9Hx32w6yw0L7F8+ZyE5kQ4jXvQweMy+p1zHpAGYTSv/S3e 2b0FqLI898ujScdYYPTdc8AvX2W4wXiCLr0JBnyCmrHgxyUQvb3dKIrSHsSkQg5iXO 1KMwRIAqWTbiOya19RwIMc0QfF+QX1SjfFQ2P1SM= Date: Wed, 24 Feb 2021 12:04:05 -0800 From: Andrew Morton To: abaci-bugfix@linux.alibaba.com, abaci@linux.alibaba.com, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 069/173] mm/memcontrol: remove redundant NULL check Message-ID: <20210224200405.jNrV0hE5t%akpm@linux-foundation.org> In-Reply-To: <20210224115824.1e289a6895087f10c41dd8d6@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Stat-Signature: qqo5q5buz1tzity6i8sqpmjben11nt4i X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 75C642000382 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614197046-474278 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yang Li Subject: mm/memcontrol: remove redundant NULL check Fix below warnings reported by coccicheck: ./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing functions is not needed. Link: https://lkml.kernel.org/r/1611216029-34397-1-git-send-email-abaci-bugfix@linux.alibaba.com Signed-off-by: Yang Li Reported-by: Abaci Robot Reviewed-by: Andrew Morton Reviewed-by: David Hildenbrand Signed-off-by: Andrew Morton --- mm/memcontrol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/mm/memcontrol.c~mm-memcontrol-remove-redundant-null-check +++ a/mm/memcontrol.c @@ -452,8 +452,7 @@ static void memcg_free_shrinker_maps(str for_each_node(nid) { pn = mem_cgroup_nodeinfo(memcg, nid); map = rcu_dereference_protected(pn->shrinker_map, true); - if (map) - kvfree(map); + kvfree(map); rcu_assign_pointer(pn->shrinker_map, NULL); } } _