From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7A3C433DB for ; Wed, 24 Feb 2021 20:02:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03C3964F20 for ; Wed, 24 Feb 2021 20:02:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03C3964F20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 88E746B0071; Wed, 24 Feb 2021 15:02:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 840508D0007; Wed, 24 Feb 2021 15:02:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 731CE6B0074; Wed, 24 Feb 2021 15:02:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id 5D1586B0071 for ; Wed, 24 Feb 2021 15:02:48 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 19C1AFB60 for ; Wed, 24 Feb 2021 20:02:48 +0000 (UTC) X-FDA: 77854234416.11.E9A05FE Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP id ECA2580192C6 for ; Wed, 24 Feb 2021 20:02:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2480D64F1F; Wed, 24 Feb 2021 20:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614196966; bh=AqNbbROry6vyOab/G1XkUcbNgncY1pD+FBLjyRYrMJI=; h=Date:From:To:Subject:In-Reply-To:From; b=RkbuNlgcJhCawzGExEhirDoZ1gmw5tf2B4jHVl00A9PYYH3a4Jk9QTCbm5NR6+z6W E8ymh/vomdXWa9/1q4u26WbSK5iRyS650G+ypvBnVGqPVQK4u4fYQOA+vWsw/f7wkM yWRMFVro4YAWagIKtxEcxbWid5OKez0QW3Qqx8Ag= Date: Wed, 24 Feb 2021 12:02:45 -0800 From: Andrew Morton To: akpm@linux-foundation.org, hch@lst.de, kent.overstreet@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, willy@infradead.org Subject: [patch 047/173] mm/filemap: simplify generic_file_read_iter Message-ID: <20210224200245.GVV1PLlJl%akpm@linux-foundation.org> In-Reply-To: <20210224115824.1e289a6895087f10c41dd8d6@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Stat-Signature: f84oariowi63fjpb6yfmcz8zmot1qpb6 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: ECA2580192C6 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614196955-601820 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Christoph Hellwig Subject: mm/filemap: simplify generic_file_read_iter Avoid the pointless goto out just for returning retval. Link: https://lkml.kernel.org/r/20210122160140.223228-19-willy@infradead.org Signed-off-by: Christoph Hellwig Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet Cc: Miaohe Lin Signed-off-by: Andrew Morton --- mm/filemap.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) --- a/mm/filemap.c~mm-filemap-simplify-generic_file_read_iter +++ a/mm/filemap.c @@ -2543,7 +2543,7 @@ generic_file_read_iter(struct kiocb *ioc ssize_t retval = 0; if (!count) - goto out; /* skip atime */ + return 0; /* skip atime */ if (iocb->ki_flags & IOCB_DIRECT) { struct file *file = iocb->ki_filp; @@ -2561,7 +2561,7 @@ generic_file_read_iter(struct kiocb *ioc iocb->ki_pos, iocb->ki_pos + count - 1); if (retval < 0) - goto out; + return retval; } file_accessed(file); @@ -2585,12 +2585,10 @@ generic_file_read_iter(struct kiocb *ioc */ if (retval < 0 || !count || iocb->ki_pos >= size || IS_DAX(inode)) - goto out; + return retval; } - retval = filemap_read(iocb, iter, retval); -out: - return retval; + return filemap_read(iocb, iter, retval); } EXPORT_SYMBOL(generic_file_read_iter); _