From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A158C433DB for ; Wed, 24 Feb 2021 20:00:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA6E964F09 for ; Wed, 24 Feb 2021 20:00:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA6E964F09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5606A6B0073; Wed, 24 Feb 2021 15:00:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E8CE6B0074; Wed, 24 Feb 2021 15:00:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FED36B0075; Wed, 24 Feb 2021 15:00:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 25CC66B0073 for ; Wed, 24 Feb 2021 15:00:37 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DD06118503B49 for ; Wed, 24 Feb 2021 20:00:36 +0000 (UTC) X-FDA: 77854228872.23.0FE38E6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP id A19293745 for ; Wed, 24 Feb 2021 20:00:30 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 085E364EF1; Wed, 24 Feb 2021 20:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614196835; bh=+o1F19wGgMUvmhOnRYeoH2ndZPYN3vtY3RMcAPJB/ek=; h=Date:From:To:Subject:In-Reply-To:From; b=dLVBJ9JiZtF0RFcNnQtHYTCKh6DDNA5l3/fJ1AA4cqgDkeDW86xcbKSI3f27NX0WL O7C7WBIByqnzBF278BMMQTFyaaSGaDWrN8aOVKyxA0B4VgUT+sgSOxQeR056WK1WK6 nZueeUMS0+WCX8TJqdVWG3YeA+fsgItOphhjjx/s= Date: Wed, 24 Feb 2021 12:00:34 -0800 From: Andrew Morton To: akpm@linux-foundation.org, gechangwei@live.cn, ghe@suse.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, junxiao.bi@oracle.com, linux-mm@kvack.org, mark@fasheh.com, mm-commits@vger.kernel.org, piaojun@huawei.com, torvalds@linux-foundation.org, yili@winhong.com Subject: [patch 008/173] ocfs2: remove redundant conditional before iput Message-ID: <20210224200034.HBgw5B2Gy%akpm@linux-foundation.org> In-Reply-To: <20210224115824.1e289a6895087f10c41dd8d6@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Stat-Signature: frtij9jq1wk7c8w38yoq3hk41woaa7du X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A19293745 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614196830-436403 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yi Li Subject: ocfs2: remove redundant conditional before iput iput handles NULL pointers gracefully, so there's no need to check the pointer before the call. Link: https://lkml.kernel.org/r/20201231040535.4091761-1-yili@winhong.com Signed-off-by: Yi Li Acked-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Signed-off-by: Andrew Morton --- fs/ocfs2/super.c | 2 -- 1 file changed, 2 deletions(-) --- a/fs/ocfs2/super.c~ocfs2-remove-redundant-conditional-before-iput +++ a/fs/ocfs2/super.c @@ -973,8 +973,6 @@ static void ocfs2_disable_quotas(struct * quota files */ dquot_disable(sb, type, DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED); - if (!inode) - continue; iput(inode); } } _