From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C2A8C433E0 for ; Wed, 24 Feb 2021 08:20:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9508964DF3 for ; Wed, 24 Feb 2021 08:20:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9508964DF3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A45DA6B0006; Wed, 24 Feb 2021 03:20:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F6A06B006C; Wed, 24 Feb 2021 03:20:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BF666B0071; Wed, 24 Feb 2021 03:20:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 72A676B0006 for ; Wed, 24 Feb 2021 03:20:19 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3B74A18043DAE for ; Wed, 24 Feb 2021 08:20:19 +0000 (UTC) X-FDA: 77852464158.12.259ED5D Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP id 930F1A0009E2 for ; Wed, 24 Feb 2021 08:20:18 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 49C62AFB5; Wed, 24 Feb 2021 08:20:17 +0000 (UTC) Date: Wed, 24 Feb 2021 09:20:14 +0100 From: Oscar Salvador To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Muchun Song , Andrew Morton Subject: Re: [PATCH] hugetlb: document the new location of page subpool pointer Message-ID: <20210224082000.GA14793@linux> References: <20210223180820.ee39f1544f2630d0eecf3a57@linux-foundation.org> <20210224040439.351882-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210224040439.351882-1-mike.kravetz@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: nf8mynsyoxqqguei1d9otqxyaw4uwtuq X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 930F1A0009E2 Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1614154818-850506 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 23, 2021 at 08:04:39PM -0800, Mike Kravetz wrote: > Expand comments, no functional change. > > Signed-off-by: Mike Kravetz Reviewed-by: Oscar Salvador Thanks > --- > include/linux/hugetlb.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index cccd1aab69dd..c0467a7a1fe0 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -476,6 +476,9 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > * huegtlb page specific state flags. These flags are located in page.private > * of the hugetlb head page. Functions created via the below macros should be > * used to manipulate these flags. > + * Note: The hugetlb page subpool pointer previously located at page.private > + * was moved to page[1].private to make room for flags in the head page. See > + * hugetlb_page_subpool(). > * > * HPG_restore_reserve - Set when a hugetlb page consumes a reservation at > * allocation time. Cleared when page is fully instantiated. Free > -- > 2.29.2 > > -- Oscar Salvador SUSE L3