From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5081FC433DB for ; Wed, 24 Feb 2021 02:49:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B785B64E21 for ; Wed, 24 Feb 2021 02:49:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B785B64E21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E479A6B0006; Tue, 23 Feb 2021 21:49:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF8206B006C; Tue, 23 Feb 2021 21:49:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0DF06B006E; Tue, 23 Feb 2021 21:49:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id B7DC26B0006 for ; Tue, 23 Feb 2021 21:49:36 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 81C08181AEF1D for ; Wed, 24 Feb 2021 02:49:36 +0000 (UTC) X-FDA: 77851630752.11.1D9CA80 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 2618280192C7 for ; Wed, 24 Feb 2021 02:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JUggJb3cAXYd36jW9el8DbW+0z3Kz4bUmTUE+LP6NRA=; b=JXFjj00htgCyW8UtVreSPf0CT6 K2Ocjrpx8DV1U7adZnTfQMf9t4pIZ+f1QuwooS0lwker/aVutTEh4g7ouv1XTmedBwfUP/BsnbSal /edwa7vtCWJpjWazjj3lh0ev3RHCyY9FVp+PrxeU7m0txi88OMM4c+J6eJ/AXYIt36VYV+lvAXHut 1t4hiZjFX7eYibQmkwz6YnqzdN0K+Df0Kyq50INlZbjeL6UAQPEQhw9FBhTnWDFpnGXWMlLq1hoB1 JQ4orsZyfx7BIJajYENsfmkMKFE3C1rXQ+rm5m0fB8LfU3KUq1oTglmIogfPL//h1eHaLpnqnuyJO M/jBdrvA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lEkEn-008qo9-Qv; Wed, 24 Feb 2021 02:49:20 +0000 Date: Wed, 24 Feb 2021 02:49:17 +0000 From: Matthew Wilcox To: Liam Howlett Cc: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Hugh Dickins Subject: Re: [PATCH v3] mm/mmap: Don't unlock VMAs in remap_file_pages() Message-ID: <20210224024917.GO2858050@casper.infradead.org> References: <20210223235010.2296915-1-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223235010.2296915-1-Liam.Howlett@Oracle.com> X-Stat-Signature: zbfm9fhzsyesp19cam6isah4tyhrz94z X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2618280192C7 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614134968-147538 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 23, 2021 at 11:50:23PM +0000, Liam Howlett wrote: > Since this call uses MAP_FIXED, do_mmap() will munlock the necessary > range. There is also an error in the loop test expression which will > evaluate as false and the loop body has never execute. > > Signed-off-by: Liam R. Howlett > Acked-by: Hugh Dickins Reviewed-by: Matthew Wilcox (Oracle)