From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A01C433E0 for ; Tue, 23 Feb 2021 20:09:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B0F8864E6B for ; Tue, 23 Feb 2021 20:09:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0F8864E6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 455EC6B0005; Tue, 23 Feb 2021 15:09:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4054F6B0006; Tue, 23 Feb 2021 15:09:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CEAD6B006E; Tue, 23 Feb 2021 15:09:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 15EC66B0005 for ; Tue, 23 Feb 2021 15:09:48 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CC91D8248047 for ; Tue, 23 Feb 2021 20:09:47 +0000 (UTC) X-FDA: 77850623214.20.8B0142F Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf14.hostedemail.com (Postfix) with ESMTP id 66458C0005C6 for ; Tue, 23 Feb 2021 20:09:40 +0000 (UTC) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11NK4XJi185352; Tue, 23 Feb 2021 15:09:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=pp1; bh=5op8Kt67whagINL33DSIe7bo2wuZ0fdfQE/1gEwLU1Y=; b=ed9n0peSYtRsa4UB9T8drO09LVi4CwL7wWJDLjrUIXod7HJSn9QBmaq3UuY9CQzpQ3yF KwQjOiLY3gNkdu1AwLVHfOFNxi7rKnknP1QMHoiR+jxiMMKUiHvC0cEIikkTqSmTB7Z1 QvrgiFUTpRw4NXkCkYEJpJEZdUoJpwIvnrCmbaOPDF8A31Uk0NFEGUAcfzsCxnh9o+50 xUYdQMRSQtdoLdHl7SlaJK9UCFtAzq3Uw/Soytvr/Xzp1aqIBYGFTp9A/jShR98fw/DF NjI+lWknOWja9WEbbFgdanemu6VfTah1M1qiRwC00CtPJEPFtSSZyNE3GGGiDiVMDygy tQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 36vkne0qgk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Feb 2021 15:09:27 -0500 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 11NK4Zcm185531; Tue, 23 Feb 2021 15:09:26 -0500 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0b-001b2d01.pphosted.com with ESMTP id 36vkne0qg3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Feb 2021 15:09:26 -0500 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11NK8RE2012157; Tue, 23 Feb 2021 20:09:24 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06fra.de.ibm.com with ESMTP id 36tsph9hta-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Feb 2021 20:09:24 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11NK99Ll18088310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Feb 2021 20:09:09 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2076442047; Tue, 23 Feb 2021 20:09:22 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CB394203F; Tue, 23 Feb 2021 20:09:17 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.51.238]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 23 Feb 2021 20:09:17 +0000 (GMT) Date: Tue, 23 Feb 2021 22:09:14 +0200 From: Mike Rapoport To: George Kennedy Cc: David Hildenbrand , Andrey Konovalov , Andrew Morton , Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Konrad Rzeszutek Wilk , Will Deacon , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev , Linux ARM , Linux Memory Management List , LKML , Dhaval Giani Subject: Re: [PATCH] mm, kasan: don't poison boot memory Message-ID: <20210223200914.GH1741768@linux.ibm.com> References: <1ac78f02-d0af-c3ff-cc5e-72d6b074fc43@redhat.com> <56c97056-6d8b-db0e-e303-421ee625abe3@redhat.com> <20210222215502.GB1741768@linux.ibm.com> <9773282a-2854-25a4-9faa-9da5dd34e371@oracle.com> <20210223103321.GD1741768@linux.ibm.com> <3ef9892f-d657-207f-d4cf-111f98dcb55c@oracle.com> <20210223154758.GF1741768@linux.ibm.com> <3a56ba38-ce91-63a6-b57c-f1726aa1b76e@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <3a56ba38-ce91-63a6-b57c-f1726aa1b76e@oracle.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-23_08:2021-02-23,2021-02-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102230169 X-Stat-Signature: a4omtpsf3p534nmwauue57ngrffxq4c7 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 66458C0005C6 Received-SPF: none (linux.ibm.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mx0a-001b2d01.pphosted.com; client-ip=148.163.158.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614110980-849614 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 23, 2021 at 01:05:05PM -0500, George Kennedy wrote: > On 2/23/2021 10:47 AM, Mike Rapoport wrote: >=20 > It now crashes here: >=20 > [=A0=A0=A0 0.051019] ACPI: Early table checksum verification disabled > [=A0=A0=A0 0.056721] ACPI: RSDP 0x00000000BFBFA014 000024 (v02 BOCHS ) > [=A0=A0=A0 0.057874] ACPI: XSDT 0x00000000BFBF90E8 00004C (v01 BOCHS BX= PCFACP > 00000001=A0=A0=A0=A0=A0 01000013) > [=A0=A0=A0 0.059590] ACPI: FACP 0x00000000BFBF5000 000074 (v01 BOCHS BX= PCFACP > 00000001 BXPC 00000001) > [=A0=A0=A0 0.061306] ACPI: DSDT 0x00000000BFBF6000 00238D (v01 BOCHS BX= PCDSDT > 00000001 BXPC 00000001) > [=A0=A0=A0 0.063006] ACPI: FACS 0x00000000BFBFD000 000040 > [=A0=A0=A0 0.063938] ACPI: APIC 0x00000000BFBF4000 000090 (v01 BOCHS BX= PCAPIC > 00000001 BXPC 00000001) > [=A0=A0=A0 0.065638] ACPI: HPET 0x00000000BFBF3000 000038 (v01 BOCHS BX= PCHPET > 00000001 BXPC 00000001) > [=A0=A0=A0 0.067335] ACPI: BGRT 0x00000000BE49B000 000038 (v01 INTEL ED= K2=A0=A0=A0=A0 > 00000002=A0=A0=A0=A0=A0 01000013) > [=A0=A0=A0 0.069030] ACPI: iBFT 0x00000000BE453000 000800 (v01 BOCHS BX= PCFACP > 00000000=A0=A0=A0=A0=A0 00000000) > [=A0=A0=A0 0.070734] XXX acpi_find_ibft_region: > [=A0=A0=A0 0.071468] XXX iBFT, status=3D0 > [=A0=A0=A0 0.072073] XXX about to call acpi_put_table()... > ibft_addr=3Dffffffffff240000 > [=A0=A0=A0 0.073449] XXX acpi_find_ibft_region(EXIT): > PANIC: early exception 0x0e IP 10:ffffffff9259f439 error 0 cr2 > 0xffffffffff240004 Right, I've missed the dereference of the ibft_addr after acpi_find_ibft_region().=20 With this change to iscsi_ibft_find.c instead of the previous one it shou= ld be better: diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_= ibft_find.c index 64bb94523281..1be7481d5c69 100644 --- a/drivers/firmware/iscsi_ibft_find.c +++ b/drivers/firmware/iscsi_ibft_find.c @@ -80,6 +80,27 @@ static int __init find_ibft_in_mem(void) done: return len; } + +static void __init acpi_find_ibft_region(unsigned long *sizep) +{ + int i; + struct acpi_table_header *table =3D NULL; + acpi_status status; + + if (acpi_disabled) + return; + + for (i =3D 0; i < ARRAY_SIZE(ibft_signs) && !ibft_addr; i++) { + status =3D acpi_get_table(ibft_signs[i].sign, 0, &table); + if (ACPI_SUCCESS(status)) { + ibft_addr =3D (struct acpi_table_ibft *)table; + *sizep =3D PAGE_ALIGN(ibft_addr->header.length); + acpi_put_table(table); + break; + } + } +} + /* * Routine used to find the iSCSI Boot Format Table. The logical * kernel address is set in the ibft_addr global variable. @@ -91,14 +112,16 @@ unsigned long __init find_ibft_region(unsigned long = *sizep) /* iBFT 1.03 section 1.4.3.1 mandates that UEFI machines will * only use ACPI for this */ =20 - if (!efi_enabled(EFI_BOOT)) + if (!efi_enabled(EFI_BOOT)) { find_ibft_in_mem(); - - if (ibft_addr) { *sizep =3D PAGE_ALIGN(ibft_addr->header.length); - return (u64)virt_to_phys(ibft_addr); + } else { + acpi_find_ibft_region(sizep); } =20 + if (ibft_addr) + return (u64)virt_to_phys(ibft_addr); + *sizep =3D 0; return 0; } > [=A0=A0=A0 0.075711] CPU: 0 PID: 0 Comm: swapper Not tainted 5.11.0-34a= 2105 #8 > [=A0=A0=A0 0.076983] Hardware name: QEMU Standard PC (i440FX + PIIX, 19= 96), BIOS > 0.0.0 02/06/2015 > [=A0=A0=A0 0.078579] RIP: 0010:find_ibft_region+0x470/0x577 --=20 Sincerely yours, Mike.