From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E49C433E0 for ; Tue, 23 Feb 2021 15:48:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9573464E20 for ; Tue, 23 Feb 2021 15:48:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9573464E20 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2E4406B0071; Tue, 23 Feb 2021 10:48:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2946E6B0072; Tue, 23 Feb 2021 10:48:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15C828D0001; Tue, 23 Feb 2021 10:48:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id EC58A6B0071 for ; Tue, 23 Feb 2021 10:48:33 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B7450173084B for ; Tue, 23 Feb 2021 15:48:33 +0000 (UTC) X-FDA: 77849964906.20.5723146 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf15.hostedemail.com (Postfix) with ESMTP id 5E538A001AAA for ; Tue, 23 Feb 2021 15:48:28 +0000 (UTC) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 11NFYKn2068294; Tue, 23 Feb 2021 10:48:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=pp1; bh=Ak0FuL6cI8F0mJstd0CancH+iLPnxA3Bs8nwiMOi/W8=; b=gVd6dsjSuj2n8tH+yahyq2faST/EOQo7WdF1K8YY1QA+E1TPaETdbeK9gKHCLlgr/yE3 qvQtGqxyi2WSNLo+9b/9ee+oLx6FM+/fg5B7abe5cLTvPk0m/v1ybbEJLFQQbLW06Cts AFUCHGXBU0WWGI6iTnrtiVFUgK/OErBbwLFP6K6WAogrTbYlQ08LzFn73lkJZW4v7+uv ojSeCH/vLXTlNF8Ln4aYhM6RnuevEvFVFqj0q4Ytn+j8VqI7CgmgLf0dPlVbTPAzAGs3 XUvPcADl0swnm1rWtyBCZYoj9LESJJ++zYMiCHuO0dnDsRq4j357pRrRrm2DdUMnDRZH Jw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 36vkfudctf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Feb 2021 10:48:08 -0500 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 11NFbBSc085265; Tue, 23 Feb 2021 10:48:08 -0500 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com with ESMTP id 36vkfudcrm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Feb 2021 10:48:08 -0500 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11NFhUPm028665; Tue, 23 Feb 2021 15:48:05 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma06fra.de.ibm.com with ESMTP id 36tsph9ep4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Feb 2021 15:48:05 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11NFlolU26345776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Feb 2021 15:47:50 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 01B75AE059; Tue, 23 Feb 2021 15:48:03 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C0698AE045; Tue, 23 Feb 2021 15:48:00 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.51.238]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 23 Feb 2021 15:48:00 +0000 (GMT) Date: Tue, 23 Feb 2021 17:47:58 +0200 From: Mike Rapoport To: George Kennedy Cc: David Hildenbrand , Andrey Konovalov , Andrew Morton , Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Konrad Rzeszutek Wilk , Will Deacon , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev , Linux ARM , Linux Memory Management List , LKML , Dhaval Giani Subject: Re: [PATCH] mm, kasan: don't poison boot memory Message-ID: <20210223154758.GF1741768@linux.ibm.com> References: <797fae72-e3ea-c0b0-036a-9283fa7f2317@oracle.com> <1ac78f02-d0af-c3ff-cc5e-72d6b074fc43@redhat.com> <56c97056-6d8b-db0e-e303-421ee625abe3@redhat.com> <20210222215502.GB1741768@linux.ibm.com> <9773282a-2854-25a4-9faa-9da5dd34e371@oracle.com> <20210223103321.GD1741768@linux.ibm.com> <3ef9892f-d657-207f-d4cf-111f98dcb55c@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <3ef9892f-d657-207f-d4cf-111f98dcb55c@oracle.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-23_08:2021-02-23,2021-02-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102230131 X-Stat-Signature: o9pbnmcqxjdh7i871o46qea43eo7s1nf X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5E538A001AAA Received-SPF: none (linux.ibm.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mx0a-001b2d01.pphosted.com; client-ip=148.163.156.1 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614095308-399420 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi George, On Tue, Feb 23, 2021 at 09:35:32AM -0500, George Kennedy wrote: >=20 > On 2/23/2021 5:33 AM, Mike Rapoport wrote: > > (re-added CC) > >=20 > > On Mon, Feb 22, 2021 at 08:24:59PM -0500, George Kennedy wrote: > > > On 2/22/2021 4:55 PM, Mike Rapoport wrote: > > > > On Mon, Feb 22, 2021 at 01:42:56PM -0500, George Kennedy wrote: > > > > > On 2/22/2021 11:13 AM, David Hildenbrand wrote: > > > > > > On 22.02.21 16:13, George Kennedy wrote: > > > > > >=20 > > > > > > The PFN 0xbe453 looks a little strange, though. Do we expect = ACPI tables > > > > > > close to 3 GiB ? No idea. Could it be that you are trying to = map a wrong > > > > > > table? Just a guess. > > > > > >=20 > > > > > > > What would be=A0 the correct way to reserve the page so tha= t the above > > > > > > > would not be hit? > > > > > > I would have assumed that if this is a binary blob, that some= one (which > > > > > > I think would be acpi code) reserved via memblock_reserve() e= arly during > > > > > > boot. > > > > > >=20 > > > > > > E.g., see drivers/acpi/tables.c:acpi_table_upgrade()->membloc= k_reserve(). > > > > > acpi_table_upgrade() gets called, but bails out before memblock= _reserve() is > > > > > called. Thus, it appears no pages are getting reserved. > > > > acpi_table_upgrade() does not actually reserve memory but rather = open > > > > codes memblock allocation with memblock_find_in_range() + > > > > memblock_reserve(), so it does not seem related anyway. > > > >=20 > > > > Do you have by chance a full boot log handy? > > > Hello Mike, > > >=20 > > > Are you after the console output? See attached. > > >=20 > > > It includes my patch to set PG_Reserved along with the dump_page() = debug > > > that David asked for - see: "page:" > > So, iBFT is indeed at pfn 0xbe453: > >=20 > > [ 0.077698] ACPI: iBFT 0x00000000BE453000 000800 (v01 BOCHS BXPCF= ACP 00000000 00000000) > > and it's in E820_TYPE_RAM region rather than in ACPI data: > >=20 > > [ 0.000000] BIOS-e820: [mem 0x0000000000810000-0x00000000008fffff]= ACPI NVS > > [ 0.000000] BIOS-e820: [mem 0x0000000000900000-0x00000000be49afff]= usable > > [ 0.000000] BIOS-e820: [mem 0x00000000be49b000-0x00000000be49bfff]= ACPI data > >=20 > > I could not find anywhere in x86 setup or in ACPI tables parsing the = code > > that reserves this memory or any other ACPI data for that matter. It = could > > be that I've missed some copying of the data to statically allocated > > initial_tables, but AFAICS any ACPI data that was not marked as such = in > > e820 tables by BIOS resides in memory that is considered as free. > >=20 >=20 > Close... >=20 > Applied the patch, see "[=A0=A0 30.136157] iBFT detected.", but now hit= the > following (missing iounmap()? see full console output attached): >=20 > diff --git a/drivers/firmware/iscsi_ibft_find.c > b/drivers/firmware/iscsi_ibft_find.c > index 64bb945..2e5e040 100644 > --- a/drivers/firmware/iscsi_ibft_find.c > +++ b/drivers/firmware/iscsi_ibft_find.c > @@ -80,6 +80,21 @@ static int __init find_ibft_in_mem(void) > =A0done: > =A0=A0=A0=A0=A0=A0=A0 return len; > =A0} > + > +static void __init acpi_find_ibft_region(void) > +{ > +=A0=A0=A0=A0=A0=A0 int i; > +=A0=A0=A0=A0=A0=A0 struct acpi_table_header *table =3D NULL; > + > +=A0=A0=A0=A0=A0=A0 if (acpi_disabled) > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return; > + > +=A0=A0=A0=A0=A0=A0 for (i =3D 0; i < ARRAY_SIZE(ibft_signs) && !ibft_a= ddr; i++) { > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 acpi_get_table(ibft_signs[i= ].sign, 0, &table); > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ibft_addr =3D (struct acpi_= table_ibft *)table; Can you try adding=20 acpi_put_table(table); here? > +=A0=A0=A0=A0=A0=A0 } > +} > + --=20 Sincerely yours, Mike.