From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61EECC433E0 for ; Tue, 23 Feb 2021 22:50:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC5B664E5C for ; Tue, 23 Feb 2021 22:50:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC5B664E5C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D1F86B0005; Tue, 23 Feb 2021 17:50:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 682486B0006; Tue, 23 Feb 2021 17:50:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 599B46B006E; Tue, 23 Feb 2021 17:50:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 43C6F6B0005 for ; Tue, 23 Feb 2021 17:50:14 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0949A8248047 for ; Tue, 23 Feb 2021 22:50:14 +0000 (UTC) X-FDA: 77851027548.06.701E8FD Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP id 8639CA0002CC for ; Tue, 23 Feb 2021 22:50:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 14CA164DF2; Tue, 23 Feb 2021 22:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614120612; bh=gCT1COJKg1ZQddedw3a/5/wlGAq6rYRQHc94K4b5n+A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DFjhHr3aj7Ef8DoNg0iZXNKHIR+pb47yvpzZu4hv67auFwt/uK2ykOSCUEBgxAm49 WJ483xaVMdfPfbaD++yrLagZVfz0R5vf70CUhliUbxN+XNm6tKexhGTMFmYwRr8r7l mI1iSgQMBBE0tQn1rqqCqfFupP89zepLcoTomzcc= Date: Tue, 23 Feb 2021 14:50:11 -0800 From: Andrew Morton To: Yu Zhao Cc: Matthew Wilcox , Hugh Dickins , Alex Shi , Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/10] mm: don't pass "enum lru_list" to lru list addition functions Message-Id: <20210223145011.0181eed96ab0091a493b51f6@linux-foundation.org> In-Reply-To: References: <20210122220600.906146-1-yuzhao@google.com> <20210122220600.906146-4-yuzhao@google.com> <20210126220111.GO308988@casper.infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: zeayrtfqu1m6ex4azb5596mnxh7kgqsb X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8639CA0002CC Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614120612-385171 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 26 Jan 2021 15:14:38 -0700 Yu Zhao wrote: > On Tue, Jan 26, 2021 at 10:01:11PM +0000, Matthew Wilcox wrote: > > On Fri, Jan 22, 2021 at 03:05:53PM -0700, Yu Zhao wrote: > > > +++ b/mm/swap.c > > > @@ -231,7 +231,7 @@ static void pagevec_move_tail_fn(struct page *page, struct lruvec *lruvec) > > > if (!PageUnevictable(page)) { > > > del_page_from_lru_list(page, lruvec, page_lru(page)); > > > ClearPageActive(page); > > > - add_page_to_lru_list_tail(page, lruvec, page_lru(page)); > > > + add_page_to_lru_list_tail(page, lruvec); > > > __count_vm_events(PGROTATED, thp_nr_pages(page)); > > > } > > > > Is it profitable to do ... > > > > - del_page_from_lru_list(page, lruvec, page_lru(page)); > > + enum lru_list lru = page_lru(page); > > + del_page_from_lru_list(page, lruvec, lru); > > ClearPageActive(page); > > - add_page_to_lru_list_tail(page, lruvec, page_lru(page)); > > + lru &= ~LRU_ACTIVE; > > + add_page_to_lru_list_tail(page, lruvec, lru); > > Ok, now we want to trade readability for size. Sure, I'll see how > much we could squeeze. As nothing has happened here and the code bloat issue remains, I'll hold this series out of 5.12-rc1.