From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF91BC433DB for ; Thu, 18 Feb 2021 22:28:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E53064EB4 for ; Thu, 18 Feb 2021 22:28:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E53064EB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AFDF06B0005; Thu, 18 Feb 2021 17:28:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A88836B006C; Thu, 18 Feb 2021 17:28:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94D446B006E; Thu, 18 Feb 2021 17:28:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 7C5426B0005 for ; Thu, 18 Feb 2021 17:28:05 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 366EF8249980 for ; Thu, 18 Feb 2021 22:28:05 +0000 (UTC) X-FDA: 77832827730.23.BB5BA80 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf16.hostedemail.com (Postfix) with ESMTP id D149880192E0 for ; Thu, 18 Feb 2021 22:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613687283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9Gh0fQKYNE13oRLVxmJHOfFd0TiAqjga28s6fBv9MLw=; b=SbTy5iazJG3paig4XNmWctshSZn/+FXgX+vifg5hKxVKGUujF4YQn5Y+C8m9GwHZBnnNeX AFxM3IlZG6J99mCXQmrSj73IjDwkqxFJeFIvqM4BC6LXhVghl7N+tRPUgMe8Kv4sDf1NiN yMYQ7isd3Q0rSmSg+F4WP9s1hIbT0dM= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-KlPv5BdlOx-1vxoQwVBkQw-1; Thu, 18 Feb 2021 17:27:59 -0500 X-MC-Unique: KlPv5BdlOx-1vxoQwVBkQw-1 Received: by mail-qk1-f197.google.com with SMTP id s6so2260425qkg.15 for ; Thu, 18 Feb 2021 14:27:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9Gh0fQKYNE13oRLVxmJHOfFd0TiAqjga28s6fBv9MLw=; b=JFg5kAKhSSiOE+NZ5nLQi5EjXlq8HR0eDRKq/inc7fcsuLvNPFs0Hg3a//QuMFL+/X Kg/sqJCgapFLM8bOoE/FtDh0yDxE82Fyl6RG8AXGhpP3akOW+sb9o4ev640Ns1X/vSlB 8hC7QwtHoQ9pdWNIVaeFsY4VPV9cTNFCE5Bo1dMt/My4UvRexpCZlohGfDYyAlW5IB5h Ca0FVaO3v0AHn2IRb6IhhjAURLWfFQ4FG1rVzdGh4Ozpoavw1KmUvYUViNSx3X1NSSca Tkg7GJEMIAmFpXAeR5NdJmsXX0yhBoPkYaBpny51YMPvxo0SshkSXEctJGOE2tj4ICqr PiBQ== X-Gm-Message-State: AOAM533vSclBblKjfUhXuIoPVg/wOMHjZqU9mlNsITM3WK2ia7ODBHdE zxX/KphuofZgTID+6azh1mEw+fTmHK/QyL836/mfFsRaw1YBseSG+ZwLqOPthOthkaR1Vx8Z9ko cmBo7UZltouM= X-Received: by 2002:a05:620a:152f:: with SMTP id n15mr6828959qkk.268.1613687279419; Thu, 18 Feb 2021 14:27:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJylhqnAtyNTelfvh8u//NliFjzQC869yB+0HPkzNfmFa04/pEhRfrGw0TQ+J8SQUzuX34QLLA== X-Received: by 2002:a05:620a:152f:: with SMTP id n15mr6828940qkk.268.1613687279215; Thu, 18 Feb 2021 14:27:59 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id d198sm5059518qke.69.2021.02.18.14.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 14:27:58 -0800 (PST) Date: Thu, 18 Feb 2021 17:27:57 -0500 From: Peter Xu To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Axel Rasmussen , Andrew Morton , Mike Rapoport , "Kirill A . Shutemov" , Matthew Wilcox , Andrea Arcangeli Subject: Re: [PATCH v3 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share() Message-ID: <20210218222757.GA6669@xz-x1> References: <20210218215434.10203-1-peterx@redhat.com> <20210218215434.10203-2-peterx@redhat.com> <76fee968-cfc2-787f-7e48-af781563756e@oracle.com> MIME-Version: 1.0 In-Reply-To: <76fee968-cfc2-787f-7e48-af781563756e@oracle.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: ouzcew61yfn3abmz5t8b36xmsrq8eiuz X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D149880192E0 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613687283-149439 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 18, 2021 at 02:13:52PM -0800, Mike Kravetz wrote: > On 2/18/21 1:54 PM, Peter Xu wrote: > > It is a preparation work to be able to behave differently in the per > > architecture huge_pte_alloc() according to different VMA attributes. > > > diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c > > index ad4b42f04988..97e0824fdbe7 100644 > > --- a/arch/sparc/mm/hugetlbpage.c > > +++ b/arch/sparc/mm/hugetlbpage.c > > @@ -280,6 +280,7 @@ unsigned long pmd_leaf_size(pmd_t pmd) { return 1UL << tte_to_shift(*(pte_t *)&p > > unsigned long pte_leaf_size(pte_t pte) { return 1UL << tte_to_shift(pte); } > > > > pte_t *huge_pte_alloc(struct mm_struct *mm, > > +pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma, > > unsigned long addr, unsigned long sz) > > { > > pgd_t *pgd; > > Didn't kernel test robot report this build error on the first patch series? That seems to be irrelevant of this series: arch/sparc/mm/hugetlbpage.c:269:22: error: 'huge_tte_to_size' defined but not used [-Werror=unused-function] Thanks, -- Peter Xu