From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC13DC433E6 for ; Thu, 18 Feb 2021 20:32:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 176EC64E5F for ; Thu, 18 Feb 2021 20:32:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 176EC64E5F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8D1D36B0006; Thu, 18 Feb 2021 15:32:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A9D26B006C; Thu, 18 Feb 2021 15:32:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BEFC6B006E; Thu, 18 Feb 2021 15:32:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 64BD46B0006 for ; Thu, 18 Feb 2021 15:32:20 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3408F8249980 for ; Thu, 18 Feb 2021 20:32:20 +0000 (UTC) X-FDA: 77832536040.14.4BB9447 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 5EDDCC000C59 for ; Thu, 18 Feb 2021 20:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613680339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4y8FXmFzZ7b7ZIO9V3YA0dBAoYUowK7ZKAVGSewkeQ4=; b=XWYPrlY6RKDAX4Y1SGUea08SRAFHnvdwr7NGi+G+rP4tzvEZ4zGSHQrqVRxgoFSCzpE1GK DynAuB6OBvdEwMaw6M4N/eCva/Y09Z210BlYjF+kL2XZw84WjnzhvZHXfvFqgzY03F/BB1 dcRrbAZNowTkkFPV4gX6rAJS8eN4+Qc= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-tdiePi2kN9u-MKGCYt8-Rg-1; Thu, 18 Feb 2021 15:32:17 -0500 X-MC-Unique: tdiePi2kN9u-MKGCYt8-Rg-1 Received: by mail-qv1-f72.google.com with SMTP id t18so1877074qva.6 for ; Thu, 18 Feb 2021 12:32:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4y8FXmFzZ7b7ZIO9V3YA0dBAoYUowK7ZKAVGSewkeQ4=; b=I9Wg5G/M1iGe85X563QjOvMGfE8FwgpDlhDQehL9NlztDjqbDERCzToU5Qz4VouG5a BBiS8GWtMiaUGT48iDXaqucanRwftNabk403/wlXlVQCeSpuigGTF9yVQ9XRgQX5cB/L HOin+vPCF2t5GwCMr6GZH5rBXp74WIMUbCijRNRvFM7FY0sYF9cKTLeteUyD7bbZb/8m VRV/tgaPMVVp8WcBEa7iOMKB4XgRiuF1uzWs+nKnqRSVrrJTDMb78ooLlRG0UsWWk5kK L1NfpcwoviWDK6LZ9uPnVDSVrx18SRl2i33NQGtObyeDYUjImAhZh00dXyAmdBoo3ae9 ENgA== X-Gm-Message-State: AOAM532dBGBtkhrkR5npp9j0+nlrBGuG4Uej0PpI5BM6gQqUMYxHsY3e YPvGyzpahdGN4j3uU2Fh2JCuQR1CxuA6tnN4GysuwkAqZWn/FtUK6se2b7cqCcTU6X+aXcjJ5Oj JBosYt8/kQiM= X-Received: by 2002:a05:620a:4152:: with SMTP id k18mr3813308qko.446.1613680336676; Thu, 18 Feb 2021 12:32:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuEAjdcbts6U/tROwOoN8WAsvUKddRotafUPo7arXZR/SHNd13h6QvZTEm/nKF+7xD9bx95Q== X-Received: by 2002:a05:620a:4152:: with SMTP id k18mr3813291qko.446.1613680336457; Thu, 18 Feb 2021 12:32:16 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id o3sm4578858qke.132.2021.02.18.12.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 12:32:15 -0800 (PST) Date: Thu, 18 Feb 2021 15:32:14 -0500 From: Peter Xu To: Axel Rasmussen Cc: Linux MM , LKML , Mike Kravetz , Mike Rapoport , Andrea Arcangeli , Matthew Wilcox , "Kirill A . Shutemov" , Andrew Morton Subject: Re: [PATCH v2 4/4] hugetlb/userfaultfd: Unshare all pmds for hugetlbfs when register wp Message-ID: <20210218203214.GD108961@xz-x1> References: <20210217204418.54259-1-peterx@redhat.com> <20210217204619.54761-1-peterx@redhat.com> <20210217204619.54761-3-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: x3aqsqjypn8ceoenbzd5kx36sty4bccy X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5EDDCC000C59 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613680337-835054 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 18, 2021 at 10:32:00AM -0800, Axel Rasmussen wrote: > > @@ -1448,6 +1449,9 @@ static int userfaultfd_register(struct userfaultfd_ctx *ctx, > > vma->vm_flags = new_flags; > > vma->vm_userfaultfd_ctx.ctx = ctx; > > > > + if (is_vm_hugetlb_page(vma) && uffd_disable_huge_pmd_share(vma)) > > + hugetlb_unshare_all_pmds(vma); > > This line yields the following error, if building with: > # CONFIG_CMA is not set > > ./fs/userfaultfd.c:1459: undefined reference to `hugetlb_unshare_all_pmds' Ouch.. Axel, you mean CONFIG_HUGETLBFS rather than CONFIG_CMA, am I right? -- Peter Xu