From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62D9C433E0 for ; Thu, 18 Feb 2021 14:49:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A494164EAD for ; Thu, 18 Feb 2021 14:49:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A494164EAD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E504F6B0006; Thu, 18 Feb 2021 09:49:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E01BB6B006C; Thu, 18 Feb 2021 09:49:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D17726B006E; Thu, 18 Feb 2021 09:49:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id B88026B0006 for ; Thu, 18 Feb 2021 09:49:02 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 550DE8249980 for ; Thu, 18 Feb 2021 14:49:02 +0000 (UTC) X-FDA: 77831670924.28.071F526 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 5463B20001F2 for ; Thu, 18 Feb 2021 14:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1qnqSwl3zPIZ18NfoUqqslAfbYk9l/Wxn1L1wgv0bjQ=; b=MR2z5mqAU4EoGlW9G8W3WH6WlP PDh8ZNDTlp6jKbO+eCxnm4OwDESOyMsjV0rH25bi7qvtsEJfU4gykwYSda0luLWxhcClo2Z7sdqmz zYmaGJqiCM0nFgd5sPKQYv6nGPKgNL2vDKKb+4cQJPgZp6+vDFyxcc8yS8QCSZ9M2PpHn0/AjYuye GzWElpMLh46s6Vr19SdcpbqTildW6Uc/my+AFvYEH8IzTYm+Gdqsg5YZvZGBckHfbNLY7R8ZaFO6N tCFNAmKcVBfrnQlb4vWZNk0ctBMO0yOhalIX03yaPqYznGmeczNNjOGCT1FOzXYOy8L8f1fcXFAuT jzcoNVRw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lCkZ0-001lVL-UI; Thu, 18 Feb 2021 14:46:12 +0000 Date: Thu, 18 Feb 2021 14:45:54 +0000 From: Matthew Wilcox To: Andrew Morton Cc: Mike Kravetz , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Zi Yan , Davidlohr Bueso , "Kirill A . Shutemov" , Andrea Arcangeli , Oscar Salvador , Joao Martins , stable@vger.kernel.org Subject: Re: [PATCH 1/2] hugetlb: fix update_and_free_page contig page struct assumption Message-ID: <20210218144554.GS2858050@casper.infradead.org> References: <20210217184926.33567-1-mike.kravetz@oracle.com> <20210217110252.185c7f5cd5a87c3f7b0c0144@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210217110252.185c7f5cd5a87c3f7b0c0144@linux-foundation.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5463B20001F2 X-Stat-Signature: ryjm9xowyxzhcs13h94z5hezw77kkmoq Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613659740-830307 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 17, 2021 at 11:02:52AM -0800, Andrew Morton wrote: > On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz wrote: > > page structs are not guaranteed to be contiguous for gigantic pages. The > > June 2014. That's a long lurk time for a bug. I wonder if some later > commit revealed it. I would suggest that gigantic pages have not seen much use. Certainly performance with Intel CPUs on benchmarks that I've been involved with showed lower performance with 1GB pages than with 2MB pages until quite recently.