From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA97C433E0 for ; Thu, 18 Feb 2021 22:29:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 985BC64D73 for ; Thu, 18 Feb 2021 22:29:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 985BC64D73 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1ABBD8D0001; Thu, 18 Feb 2021 17:29:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15C466B0070; Thu, 18 Feb 2021 17:29:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 099A98D0001; Thu, 18 Feb 2021 17:29:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id E7C326B006E for ; Thu, 18 Feb 2021 17:29:08 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B8A938249980 for ; Thu, 18 Feb 2021 22:29:08 +0000 (UTC) X-FDA: 77832830376.08.4776EFE Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP id 2A35F407F8FE for ; Thu, 18 Feb 2021 22:29:05 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DF3D764EBA; Thu, 18 Feb 2021 22:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1613687347; bh=rL+rF3aa+dRHFuS1O5WovDmtQd0LOmlqemVv8e9wg6Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K2/rwDC5QGbJwRafcXIHiVPpkuIMcHBTn8kU6t4PYFVnXmX3r6nIkG78diR9CDjrq Kzhnj3nyt6PjCDU22KUqFCSeGF4X1aHgSHXCzP1LNlwqcvJOo2snTZM30kleD52iKv 5HimzOFtdBKc4UkH4gLzH0TQWaWXUoiw2je4XdGg= Date: Thu, 18 Feb 2021 14:29:06 -0800 From: Andrew Morton To: Dan Carpenter Cc: kbuild@lists.01.org, Anshuman Khandual , lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , David Hildenbrand , Oscar Salvador Subject: Re: [linux-next:master 10191/10581] mm/memremap.c:270 pagemap_range() warn: missing error code 'error' Message-Id: <20210218142906.b789221a9f87eaf089034a97@linux-foundation.org> In-Reply-To: <20210215124053.GJ2087@kadam> References: <20210215124053.GJ2087@kadam> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2A35F407F8FE X-Stat-Signature: aajcgnww4ygi7yh397wc5shrehrczbpy Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613687345-975137 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 15 Feb 2021 15:40:53 +0300 Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 671176b0016c80b3943cb5387312c886aba3308d > commit: 719fa3d6ddb50d3035c713c27feeae8b249eb586 [10191/10581] mm/memory_hotplug: prevalidate the address range being added with platform > config: x86_64-randconfig-m001-20210211 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > mm/memremap.c:270 pagemap_range() warn: missing error code 'error' > Thanks, I did this: --- a/mm/memremap.c~mm-memory_hotplug-prevalidate-the-address-range-being-added-with-platform-fix +++ a/mm/memremap.c @@ -266,8 +266,10 @@ static int pagemap_range(struct dev_page if (error) goto err_pfn_remap; - if (!mhp_range_allowed(range->start, range_len(range), !is_private)) + if (!mhp_range_allowed(range->start, range_len(range), !is_private)) { + error = -EINVAL; goto err_pfn_remap; + } mem_hotplug_begin(); _