Re: [PATCH 1/4] hugetlb: Pass vma into huge_pte_alloc() and huge_pmd_share()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5882 bytes --]

Hi Peter,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on linux/master linus/master hnaz-linux-mm/master v5.11 next-20210217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Peter-Xu/hugetlb-Disable-huge-pmd-unshare-for-uffd-wp/20210218-003520
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/58ca9ac367f24752915f352fa9ae1ae027a29de3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Peter-Xu/hugetlb-Disable-huge-pmd-unshare-for-uffd-wp/20210218-003520
        git checkout 58ca9ac367f24752915f352fa9ae1ae027a29de3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/sparc/mm/hugetlbpage.c:285:1: error: expected ';', ',' or ')' before '{' token
     285 | {
         | ^
>> arch/sparc/mm/hugetlbpage.c:269:22: error: 'huge_tte_to_size' defined but not used [-Werror=unused-function]
     269 | static unsigned long huge_tte_to_size(pte_t pte)
         |                      ^~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +285 arch/sparc/mm/hugetlbpage.c

c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  268  
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01 @269  static unsigned long huge_tte_to_size(pte_t pte)
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  270  {
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  271  	unsigned long size = 1UL << huge_tte_to_shift(pte);
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  272  
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  273  	if (size == REAL_HPAGE_SIZE)
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  274  		size = HPAGE_SIZE;
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  275  	return size;
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  276  }
c7d9f77d33a779 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-01  277  
e6e4f42eb773c1 arch/sparc/mm/hugetlbpage.c   Peter Zijlstra 2020-11-13  278  unsigned long pud_leaf_size(pud_t pud) { return 1UL << tte_to_shift(*(pte_t *)&pud); }
e6e4f42eb773c1 arch/sparc/mm/hugetlbpage.c   Peter Zijlstra 2020-11-13  279  unsigned long pmd_leaf_size(pmd_t pmd) { return 1UL << tte_to_shift(*(pte_t *)&pmd); }
e6e4f42eb773c1 arch/sparc/mm/hugetlbpage.c   Peter Zijlstra 2020-11-13  280  unsigned long pte_leaf_size(pte_t pte) { return 1UL << tte_to_shift(pte); }
e6e4f42eb773c1 arch/sparc/mm/hugetlbpage.c   Peter Zijlstra 2020-11-13  281  
a5516438959d90 arch/sparc64/mm/hugetlbpage.c Andi Kleen     2008-07-23  282  pte_t *huge_pte_alloc(struct mm_struct *mm,
58ca9ac367f247 arch/sparc/mm/hugetlbpage.c   Peter Xu       2021-02-17  283  pte_t *huge_pte_alloc(struct mm_struct *mm, struct vm_area_struct *vma,
a5516438959d90 arch/sparc64/mm/hugetlbpage.c Andi Kleen     2008-07-23  284  			unsigned long addr, unsigned long sz)
^1da177e4c3f41 arch/sparc64/mm/hugetlbpage.c Linus Torvalds 2005-04-16 @285  {
^1da177e4c3f41 arch/sparc64/mm/hugetlbpage.c Linus Torvalds 2005-04-16  286  	pgd_t *pgd;
5637bc50483404 arch/sparc/mm/hugetlbpage.c   Mike Rapoport  2019-11-24  287  	p4d_t *p4d;
^1da177e4c3f41 arch/sparc64/mm/hugetlbpage.c Linus Torvalds 2005-04-16  288  	pud_t *pud;
dcd1912d21a025 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-06  289  	pmd_t *pmd;
^1da177e4c3f41 arch/sparc64/mm/hugetlbpage.c Linus Torvalds 2005-04-16  290  
^1da177e4c3f41 arch/sparc64/mm/hugetlbpage.c Linus Torvalds 2005-04-16  291  	pgd = pgd_offset(mm, addr);
5637bc50483404 arch/sparc/mm/hugetlbpage.c   Mike Rapoport  2019-11-24  292  	p4d = p4d_offset(pgd, addr);
5637bc50483404 arch/sparc/mm/hugetlbpage.c   Mike Rapoport  2019-11-24  293  	pud = pud_alloc(mm, p4d, addr);
df7b2155bbe755 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-08-11  294  	if (!pud)
df7b2155bbe755 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-08-11  295  		return NULL;
df7b2155bbe755 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-08-11  296  	if (sz >= PUD_SIZE)
4dbe87d5a70215 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-08-11  297  		return (pte_t *)pud;
dcd1912d21a025 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-06  298  	pmd = pmd_alloc(mm, pud, addr);
dcd1912d21a025 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-06  299  	if (!pmd)
dcd1912d21a025 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-02-06  300  		return NULL;
59f1183dd368f1 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-03-03  301  	if (sz >= PMD_SIZE)
4dbe87d5a70215 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-08-11  302  		return (pte_t *)pmd;
4dbe87d5a70215 arch/sparc/mm/hugetlbpage.c   Nitin Gupta    2017-08-11  303  	return pte_alloc_map(mm, pmd, addr);
^1da177e4c3f41 arch/sparc64/mm/hugetlbpage.c Linus Torvalds 2005-04-16  304  }
^1da177e4c3f41 arch/sparc64/mm/hugetlbpage.c Linus Torvalds 2005-04-16  305  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68769 bytes --]