From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D30C433E0 for ; Wed, 17 Feb 2021 19:44:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E69864E4A for ; Wed, 17 Feb 2021 19:44:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E69864E4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 91A8F6B0006; Wed, 17 Feb 2021 14:44:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CCCD6B006C; Wed, 17 Feb 2021 14:44:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BB066B006E; Wed, 17 Feb 2021 14:44:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 66BBD6B0006 for ; Wed, 17 Feb 2021 14:44:43 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 28A221856A8D0 for ; Wed, 17 Feb 2021 19:44:43 +0000 (UTC) X-FDA: 77828787246.14.fang59_5e0044e2764f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 125961832B990 for ; Wed, 17 Feb 2021 19:44:43 +0000 (UTC) X-HE-Tag: fang59_5e0044e2764f X-Filterd-Recvd-Size: 5562 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Feb 2021 19:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613591081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DKRCGD5cZBFDckHkhQGxjYspyMuPSVpV7imvsh15Fwg=; b=iLVjX7Wd+HlriVFyBUvM2uJ/baXyjJBP9wZw1Xi/HX8v6RAMX9F6FFV6gJY4ywogzN4ax/ vzv03VFupsjm5aJVTUKOZFsMPTDNTmG1HX7YvLZZHZrX3cfyopaNWeLLM7ex6Q09SWWwMI I/85lIgc3qNh6Xe4LBhQXwdMzRALwXU= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-dff4sHlrPOe_FLPmQEFR-Q-1; Wed, 17 Feb 2021 14:44:39 -0500 X-MC-Unique: dff4sHlrPOe_FLPmQEFR-Q-1 Received: by mail-qt1-f199.google.com with SMTP id l1so10905888qtv.2 for ; Wed, 17 Feb 2021 11:44:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DKRCGD5cZBFDckHkhQGxjYspyMuPSVpV7imvsh15Fwg=; b=Th0cZqVQjQ71vQfVPd9b3yZtYjE7vKZts7niK57ECQ2gkc3m67n0CDDqR/vR9l6CJB Gckoslzue/1XpZl5vZhX4BUmMp1bzKNNuCHcVificr+AaeSuLmtsbwo1/NgGPy+lbADt rWLAfUcM+1LtzagciTr4tNYH2qrm+qI8fEsR9Bk5slqSwO8OszKHAbpbi2b0098jRDsA vAgv4p8IM6gm9vNd6lIOimakKv0yad9dkcIW2T/8Ry4TxtYtKXK+SgtwhtvORFuBbsr+ 5Gu9BgA2p4UK9Rzgt5UlIH59pKD2fFkoTJCv96g2TodU/EMiGs8gpg0sqGhYJP3AZ5rw c8dA== X-Gm-Message-State: AOAM532aJN4lERAX9xkG3kQa2LNRhDadbt1HOv9LKe6CFviMx9JN6XQ2 95f86afcp3gA8kaP4IPOe2iGcJ5QFs0pr0db18om6tVlAuI/dnNTNiyePuhIwwPEYpQfi0oIff3 aYfU2KYb/vu4= X-Received: by 2002:a37:e20b:: with SMTP id g11mr832456qki.292.1613591078916; Wed, 17 Feb 2021 11:44:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzmn0YnwZ3NDVqO0cMhaXsErwcpE5p4rLVKMLyL5IWYZzrdUFReeIRZBso5fLx1tUu0zEu6dg== X-Received: by 2002:a37:e20b:: with SMTP id g11mr832433qki.292.1613591078685; Wed, 17 Feb 2021 11:44:38 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id k187sm2318732qkc.74.2021.02.17.11.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 11:44:38 -0800 (PST) Date: Wed, 17 Feb 2021 14:44:36 -0500 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, shu wang , Axel Rasmussen , Andrea Arcangeli , Heiko Carstens , Alexey Dobriyan , Matthew Wilcox , Michel Lespinasse , Andrew Morton Subject: Re: [RFC PATCH 4/5] hugetlb: don't permit pmd sharing if soft dirty in use Message-ID: <20210217194436.GD6519@xz-x1> References: <20210211000322.159437-1-mike.kravetz@oracle.com> <20210211000322.159437-5-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20210211000322.159437-5-mike.kravetz@oracle.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 10, 2021 at 04:03:21PM -0800, Mike Kravetz wrote: > If page modifications are being monitoried with the soft dirty mechanism, > then this information is contained in page table entries. Tracking is > enabled on a 'per-process' basis. hugetlb pmd sharing allows processes > to share page table entries. This makes pmd sharing incompatible with > soft dirty monitoring. So, pmd sharing must be disabled if soft dirty > tracking is in use. > > The VM_SOFTDIRTY flag is set in all vma's by default. When soft dirty > monitoring is started, the flag is cleared. We can therefore allow pmd > sharing in vmas with the VM_SOFTDIRTY flag set. Check this when deciding > to perform pmd sharing. > > A subsequent patch will add code to allow soft dirty monitoring for hugetlb > vmas. Any existing pmd sharing will be undone at that time. > > Signed-off-by: Mike Kravetz > --- > mm/hugetlb.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index b561b6867ec1..cf4aa63be9b1 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5285,6 +5285,13 @@ static bool vma_shareable(struct vm_area_struct *vma, unsigned long addr) > unsigned long base = addr & PUD_MASK; > unsigned long end = base + PUD_SIZE; > > + /* > + * Do not allow pmd sharing if soft dirty tracking is in use. > + */ > + if (IS_ENABLED(CONFIG_MEM_SOFT_DIRTY) && > + !(vma->vm_flags & VM_SOFTDIRTY)) > + return false; > + Reviewed-by: Peter Xu The indent of using three tabs is a bit weird to me, though.. I do see this happen somewhere else in the repo too, so maybe it's a way to indent that I don't know. Thanks, -- Peter Xu