From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F0CC433E0 for ; Wed, 17 Feb 2021 13:46:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5A59464E4D for ; Wed, 17 Feb 2021 13:46:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A59464E4D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF4C76B0006; Wed, 17 Feb 2021 08:46:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA4696B006C; Wed, 17 Feb 2021 08:46:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B9CF6B006E; Wed, 17 Feb 2021 08:46:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 81A146B0006 for ; Wed, 17 Feb 2021 08:46:53 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4607D6116 for ; Wed, 17 Feb 2021 13:46:53 +0000 (UTC) X-FDA: 77827885506.30.elbow59_48067b52764c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 21A72180B31BC for ; Wed, 17 Feb 2021 13:46:53 +0000 (UTC) X-HE-Tag: elbow59_48067b52764c X-Filterd-Recvd-Size: 1988 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Feb 2021 13:46:52 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AFCB2B761; Wed, 17 Feb 2021 13:46:51 +0000 (UTC) Date: Wed, 17 Feb 2021 14:46:49 +0100 From: Oscar Salvador To: Michal Hocko Cc: Andrew Morton , Mike Kravetz , David Hildenbrand , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb pages Message-ID: <20210217134649.GB32488@linux> References: <20210217100816.28860-1-osalvador@suse.de> <20210217100816.28860-3-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 17, 2021 at 02:36:31PM +0100, Michal Hocko wrote: > On Wed 17-02-21 11:08:16, Oscar Salvador wrote: > > In-use hugetlb pages can be migrated as any other page (LRU > > and Movable), so let alloc_contig_range handle them. > > > > All we need is to succesfully isolate such page. > > Again, this is missing a problem statement and a justification why we > want/need this. Heh, I was poor in words. "alloc_contig_range() will fail miserably if it finds a HugeTLB page within the range without a chance to handle them. Since HugeTLB pages can be migrated as any other page (LRU and Movable), it does not make sense to bail out. Enable the interface to recognize in-use HugeTLB pages and have a chance to migrate them" What about something along those lines? -- Oscar Salvador SUSE L3