From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FDD2C433DB for ; Tue, 16 Feb 2021 05:38:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E921F64DDA for ; Tue, 16 Feb 2021 05:38:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E921F64DDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 78C518D0153; Tue, 16 Feb 2021 00:38:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73BD58D0140; Tue, 16 Feb 2021 00:38:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 603A68D0153; Tue, 16 Feb 2021 00:38:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 482F98D0140 for ; Tue, 16 Feb 2021 00:38:00 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0C35883F5 for ; Tue, 16 Feb 2021 05:38:00 +0000 (UTC) X-FDA: 77823024720.01.4939A27 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf26.hostedemail.com (Postfix) with ESMTP id E3D5340001DE for ; Tue, 16 Feb 2021 05:37:56 +0000 (UTC) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 11G5UYNr089958; Tue, 16 Feb 2021 00:37:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=XIHqzWzFjCU7ytZ2ZF2D7VR3Tzqllwx1s6KZuDCk1jo=; b=ErOal5At9sOguJ80NFftMsaKjhvbJ5I6JnHiWe0bm0fMshWFqlUybPC4w70bjAUrRUpa 3o+KH372hlVXOoVIiuIu8sfP1YP5i6rUj5uLKiddml1IgWYIFzERmORgOrwBUUn4gCST QOeguliVfL99T0qVF8o6coFJgoJpsEdMBawZXGK4PQl3MhJTazJY0rA+aN65AvFjLS++ bCQ10omezsbLqiIt6tPZ33Trsc4tN+fuc8P5T3kialC1X3t4FAdht42mwrag13Vp1GGY vSO95mkAC0Vq+krSBXISrsdOfY8TeY6XvuoNCmjiSvUphhYja1ZNTselkoFDgAhmpVbF ug== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 36r6yq1j3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Feb 2021 00:37:47 -0500 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11G5bjIJ027308; Tue, 16 Feb 2021 05:37:45 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma06ams.nl.ibm.com with ESMTP id 36p61haey9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Feb 2021 05:37:45 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11G5bhuY14614838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Feb 2021 05:37:43 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3674552051; Tue, 16 Feb 2021 05:37:43 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.156.52]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id AE79E5204F; Tue, 16 Feb 2021 05:37:42 +0000 (GMT) Date: Tue, 16 Feb 2021 07:37:40 +0200 From: Mike Rapoport To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v2 5/6] mm/mempolicy: Rewrite alloc_pages documentation Message-ID: <20210216053740.GW299309@linux.ibm.com> References: <20210215210203.3827513-1-willy@infradead.org> <20210215210203.3827513-6-willy@infradead.org> <20210215214740.GU299309@linux.ibm.com> <20210215223257.GG2858050@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210215223257.GG2858050@casper.infradead.org> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-15_16:2021-02-12,2021-02-15 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=999 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102160048 X-Stat-Signature: gmpit5ky3uiqjpdjymsoqorgftqnaw7y X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E3D5340001DE Received-SPF: none (linux.ibm.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mx0a-001b2d01.pphosted.com; client-ip=148.163.158.5 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613453876-233888 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 15, 2021 at 10:32:57PM +0000, Matthew Wilcox wrote: > On Mon, Feb 15, 2021 at 11:47:40PM +0200, Mike Rapoport wrote: > > > /** > > > + * alloc_pages - Allocate pages. > > > + * @gfp: GFP flags. > > > + * @order: Power of two of number of pages to allocate. > > > * > > > + * Allocate 1 << @order contiguous pages. The physical address of the > > > + * first page is naturally aligned (eg an order-3 allocation will be aligned > > > + * to a multiple of 8 * PAGE_SIZE bytes). The NUMA policy of the current > > > + * process is honoured when in process context. > > > * > > > + * Context: Can be called from any context, providing the appropriate GFP > > > + * flags are used. > > > + * Return: NULL when no page can be allocated. > > > > Don't you want to mention the return value on success? It is quite obvious, > > but still. > > Sure. Preferred wording? > > + * Return: The page on success or NULL if allocation fails. Works for me :) -- Sincerely yours, Mike.