From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60FDAC433DB for ; Mon, 15 Feb 2021 21:51:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F152D64DE8 for ; Mon, 15 Feb 2021 21:51:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F152D64DE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 635AB8D0148; Mon, 15 Feb 2021 16:51:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E69D8D0140; Mon, 15 Feb 2021 16:51:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FCBE8D0148; Mon, 15 Feb 2021 16:51:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 3A2D28D0140 for ; Mon, 15 Feb 2021 16:51:51 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F3819815A for ; Mon, 15 Feb 2021 21:51:50 +0000 (UTC) X-FDA: 77821850022.14.hair40_1102b862763e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id D00D618229837 for ; Mon, 15 Feb 2021 21:51:50 +0000 (UTC) X-HE-Tag: hair40_1102b862763e X-Filterd-Recvd-Size: 5111 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Feb 2021 21:51:50 +0000 (UTC) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 11FLUYke103731; Mon, 15 Feb 2021 16:51:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=jnrGH0xav43g1ifSdY6QY4LynBO+zndLYyx6hJ7hmp0=; b=ffCvq6qWdvQXYw83GMVGSGTGotbYEIAar2FENmtpzQrNZmUtl4f1yvRQ5hWRLVxeZm35 ceI30DhZaebhJ/ZkL80tzYU4EVcnV1NXbQSMVn3uJSqViyPJR5DLD4Nmr0bTPpqEqX52 BdNGQjEVHVQ+amM9wu9vKG+tCExyihDWY4vW0lBo6J17WHN/9gAC1UCEwlPgejjuMYgk Bu6g7AAHHKO5I8o0dHEbptq5BTtVrmmdCYVZcnGlSeA4iHXTgL1DYb4LWjUssHosFtBE earwS1fNxuAdKrKkEINA3Au9RSJ2y6NqHivNrXMI7GBsSadW3gd1uQQ3wK0f/OFbRz7V 7w== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 36r0p58tye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Feb 2021 16:51:48 -0500 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11FLlTc3011004; Mon, 15 Feb 2021 21:51:46 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03ams.nl.ibm.com with ESMTP id 36p6d8a6up-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Feb 2021 21:51:46 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11FLpXSG36307342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Feb 2021 21:51:33 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 152F0AE045; Mon, 15 Feb 2021 21:51:44 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A1A3AE051; Mon, 15 Feb 2021 21:51:43 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.156.52]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 15 Feb 2021 21:51:43 +0000 (GMT) Date: Mon, 15 Feb 2021 23:51:41 +0200 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v2 6/6] mm/mempolicy: Fix mpol_misplaced kernel-doc Message-ID: <20210215215141.GV299309@linux.ibm.com> References: <20210215210203.3827513-1-willy@infradead.org> <20210215210203.3827513-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210215210203.3827513-7-willy@infradead.org> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-02-15_16:2021-02-12,2021-02-15 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 spamscore=0 mlxlogscore=899 bulkscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102150160 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 15, 2021 at 09:02:03PM +0000, Matthew Wilcox (Oracle) wrote: > Sphinx interprets the Return section as a list and complains about it. > Turn it into a sentence and move it to the end of the kernel-doc to > fit the kernel-doc style. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Mike Rapoport > --- > Documentation/core-api/mm-api.rst | 1 + > mm/mempolicy.c | 11 ++++------- > 2 files changed, 5 insertions(+), 7 deletions(-) ... > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 96c98ce16727..577f59c8f327 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2456,14 +2456,11 @@ static void sp_free(struct sp_node *n) > * @addr: virtual address where page mapped > * > * Lookup current policy node id for vma,addr and "compare to" page's > - * node id. > - * > - * Returns: > - * -1 - not misplaced, page is in the right node > - * node - node id where the page should be > - * > - * Policy determination "mimics" alloc_page_vma(). > + * node id. Policy determination "mimics" alloc_page_vma(). > * Called from fault path where we know the vma and faulting address. > + * > + * Return: -1 if the page is in a node that is valid for this policy, or a > + * suitable node ID to allocate a replacement page from. I think it's possible to use lists in the Return: descriptions with the right combination of spaces, asterisks and dashes, but this description is way better anyway. -- Sincerely yours, Mike.