From: Andrew Morton <akpm@linux-foundation.org>
To: Barry Song <song.bao.hua@hisilicon.com>
Cc: <linux-mm@kvack.org>
Subject: Re: [PATCH v2 0/2] Fix the compatibility of zsmalloc and zswap
Date: Sat, 13 Feb 2021 14:33:38 -0800 [thread overview]
Message-ID: <20210213143338.c47a61b1d86e91c20ca2558e@linux-foundation.org> (raw)
In-Reply-To: <20210213075831.10852-1-song.bao.hua@hisilicon.com>
On Sat, 13 Feb 2021 20:58:29 +1300 Barry Song <song.bao.hua@hisilicon.com> wrote:
> The compatibility of zsmalloc and zswap was broken by commit 1ec3b5fe6eec
> ("mm/zswap: move to use crypto_acomp API for hardware acceleration").
>
> patch #1 add a flag to zpool, then zswap used it to determine if zpool
> drivers such as zbud/z3fold/zsmalloc will enter an atomic context after
> mapping. the difference between zbud/z3fold and zsmalloc is that zsmalloc
> requires an atomic context since its map function holds a
> preempt-disabled lock, but zbud/z3fold don't require an atomic context.
> so patch #2 set flag sleep_mapped to true indicates that zbud/z3fold can
> sleep after mapping. zsmalloc didn't support sleep after mapping, so not
> set that flag to true.
OK, thanks for cleaning all that up.
I'll send it in to Linus for 5.11 if there will be a -rc8. Otherwise
for 5.12-rc1 with a cc:stable so this gets repaired in 5.11.1.
prev parent reply other threads:[~2021-02-13 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 7:58 Barry Song
2021-02-13 7:58 ` [PATCH v2 1/2] mm/zswap: add a flag to indicate if zpool can do sleep map Barry Song
2021-02-13 7:58 ` [PATCH v2 2/2] mm: set the sleep_mapped to true for zbud and z3fold Barry Song
2021-02-13 22:33 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210213143338.c47a61b1d86e91c20ca2558e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox