From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE01C433E0 for ; Fri, 12 Feb 2021 23:04:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2772B64DAD for ; Fri, 12 Feb 2021 23:04:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2772B64DAD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B9B8F8D00A9; Fri, 12 Feb 2021 18:04:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4D628D0060; Fri, 12 Feb 2021 18:04:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A63738D00A9; Fri, 12 Feb 2021 18:04:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 8E9338D0060 for ; Fri, 12 Feb 2021 18:04:55 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5A3CE1803D0E9 for ; Fri, 12 Feb 2021 23:04:55 +0000 (UTC) X-FDA: 77811147750.13.chain45_421588227625 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 36D53180F8B9D for ; Fri, 12 Feb 2021 23:04:55 +0000 (UTC) X-HE-Tag: chain45_421588227625 X-Filterd-Recvd-Size: 2015 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [193.142.43.52]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Fri, 12 Feb 2021 23:04:54 +0000 (UTC) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1lAhUW-0003Sk-7S; Sat, 13 Feb 2021 00:04:48 +0100 Date: Sat, 13 Feb 2021 00:04:48 +0100 From: Florian Westphal To: kernel test robot Cc: Florian Westphal , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Pablo Neira Ayuso Subject: Re: [linux-next:master 5178/10581] net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here Message-ID: <20210212230448.GG2766@breakpoint.cc> References: <202102130043.4UIBML4o-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202102130043.4UIBML4o-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 671176b0016c80b3943cb5387312c886aba3308d > commit: 83ace77f51175023c3757e2d08a92565f9b1c7f3 [5178/10581] netfilter: ctnetlink: remove get_ct indirection > >> net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here [-Wuninitialized] > if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0) > ^~~~~~ > net/netfilter/nfnetlink_queue.c:391:2: note: variable 'ctinfo' is declared here Looks like a false positive. ctinfo is uninitialized only if ct == NULL. The config even has "CONFIG_NF_CONNTRACK is no set" so ct is always NULL. Could be "fixed" by adding aother ifdef but it would add even more clutter to an huge function.