From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C5EC433E0 for ; Fri, 12 Feb 2021 22:44:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A0FF64E92 for ; Fri, 12 Feb 2021 22:44:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A0FF64E92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2352B8D00A3; Fri, 12 Feb 2021 17:44:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BED68D0060; Fri, 12 Feb 2021 17:44:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 038878D00A3; Fri, 12 Feb 2021 17:44:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id C9A288D0060 for ; Fri, 12 Feb 2021 17:44:11 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8DFBB18369443 for ; Fri, 12 Feb 2021 22:44:11 +0000 (UTC) X-FDA: 77811095502.23.snow01_57058af27624 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 71D5537604 for ; Fri, 12 Feb 2021 22:44:11 +0000 (UTC) X-HE-Tag: snow01_57058af27624 X-Filterd-Recvd-Size: 5787 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Fri, 12 Feb 2021 22:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613169850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nUItIC8AvpxN/ifxyQrgm5PhbIt2D7FId215syGUsUA=; b=cuwMLVZ2FzMEVhBupYdFUzTcYJCJAsBrbaSVaW1DJGuErC4uMy5X3491zJvWBIhKYCKpGO eRXMcbZ7/AaeWBahdokZuJcRVj2epfuM3EWg55obuqaXy4UU9agY7qdIfH0YXG4KbxfmjB 7OQRgfBkaViXwUbdT5qFjdsgre27QqU= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-N1BtH1kAPA6el-qyCg7srA-1; Fri, 12 Feb 2021 17:44:08 -0500 X-MC-Unique: N1BtH1kAPA6el-qyCg7srA-1 Received: by mail-qk1-f198.google.com with SMTP id 14so779282qkv.17 for ; Fri, 12 Feb 2021 14:44:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nUItIC8AvpxN/ifxyQrgm5PhbIt2D7FId215syGUsUA=; b=E3YydhL59hMtG5zs3XxEoxZcL71NrDjATsP3Kb/by0KRdsCv1Xgy9J+8KsU3HDigBB Gz4rk+RQHiRNUfVJwZ8vhjhgAP+Ez5Ao46V76aJmWLLhVC0ZycEgD8jiOBhmtP4zWssM WzLhKTOGl1eFJNJz/kDTHA25dc4MyOZpzk/yH9k5QWUSbMh4mtPYkWbm11iHmHdNmxbI pq7iNEo/g+VhVE1ALkBmSqZGUc+raKnUsCX507pR8/DfSJzcqOYywUGEkcUZNmv4z1Nr bq39Pdb17VrQA3RDqoAqmDd25IddwbwjDVbNhr3TMX3atc+KDMuyPSQMZP3x1fi6RbUx jHaA== X-Gm-Message-State: AOAM531anEZ4zIV/NCh6hDEXKmRQ86sAkDPwkWaTtOmx1Qqqbq9vx5F7 c1cwCYHTgz4yGH3UIZaGtySSKzpLUmtQL45JBsy7H+4lSxXMhqxLeVXjrOk4a72lXK/IswKhguI qf/Wdw1oCUvs= X-Received: by 2002:aed:2705:: with SMTP id n5mr4756494qtd.36.1613169848286; Fri, 12 Feb 2021 14:44:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJybkH7EUY1ijGZtLtkL/3zdNnvQq/skhUoxC9qRmqlhCz+jadj7lnP17oSpV43oxXUFKfZbcw== X-Received: by 2002:aed:2705:: with SMTP id n5mr4756479qtd.36.1613169848101; Fri, 12 Feb 2021 14:44:08 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id f188sm7216631qkj.110.2021.02.12.14.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 14:44:07 -0800 (PST) Date: Fri, 12 Feb 2021 17:44:05 -0500 From: Peter Xu To: Matthew Wilcox Cc: Axel Rasmussen , Alexander Viro , Alexey Dobriyan , Andrea Arcangeli , Andrew Morton , Anshuman Khandual , Catalin Marinas , Chinwen Chang , Huang Ying , Ingo Molnar , Jann Horn , Jerome Glisse , Lokesh Gidra , Michael Ellerman , Michal =?utf-8?Q?Koutn=C3=BD?= , Michel Lespinasse , Mike Kravetz , Mike Rapoport , Nicholas Piggin , Shaohua Li , Shawn Anastasio , Steven Rostedt , Steven Price , Vlastimil Babka , LKML , linux-fsdevel@vger.kernel.org, Linux MM , Adam Ruprecht , Cannon Matthews , "Dr . David Alan Gilbert" , David Rientjes , Mina Almasry , Oliver Upton Subject: Re: [PATCH v5 05/10] userfaultfd: add minor fault registration mode Message-ID: <20210212224405.GF3171@xz-x1> References: <20210210212200.1097784-1-axelrasmussen@google.com> <20210210212200.1097784-6-axelrasmussen@google.com> <20210212222145.GB2858050@casper.infradead.org> MIME-Version: 1.0 In-Reply-To: <20210212222145.GB2858050@casper.infradead.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 12, 2021 at 10:21:45PM +0000, Matthew Wilcox wrote: > On Thu, Feb 11, 2021 at 11:28:09AM -0800, Axel Rasmussen wrote: > > Ah, I had added this just after VM_UFFD_WP, without noticing that this > > would be sharing a bit with VM_LOCKED. That seems like not such a > > great idea. > > > > I don't see another unused bit, and I don't see some other obvious > > candidate to share with. So, the solution that comes to mind is > > it'd be even better if you didn't use the last unused bit for UFFD_WP. > not sure how feasible that is, but you can see we're really short on > bits here. UFFD_WP is used now for anonymouse already.. And the support for hugetlbfs and shmem is in rfc stage on the list. Is it possible to use CONFIG_ARCH_USES_HIGH_VMA_FLAGS here? So far uffd-wp is only working for 64 bit x86 too due to enlarged pte space. Maybe we can also let minor mode to only support 64 bit hosts. Thanks, -- Peter Xu