From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7197FC433E0 for ; Tue, 9 Feb 2021 21:42:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2979364EE0 for ; Tue, 9 Feb 2021 21:42:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2979364EE0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A86B06B0080; Tue, 9 Feb 2021 16:42:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A38FF6B0081; Tue, 9 Feb 2021 16:42:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94EBB6B0082; Tue, 9 Feb 2021 16:42:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 7EF7F6B0080 for ; Tue, 9 Feb 2021 16:42:38 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4AD47160DD for ; Tue, 9 Feb 2021 21:42:38 +0000 (UTC) X-FDA: 77800053996.23.month79_34002342760a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 2CD9537604 for ; Tue, 9 Feb 2021 21:42:38 +0000 (UTC) X-HE-Tag: month79_34002342760a X-Filterd-Recvd-Size: 2411 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 21:42:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 968F464EE2; Tue, 9 Feb 2021 21:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1612906956; bh=OW+Ju7E4y3ERDeDaWlFQpZDmetJfYur5KmZynBxTgtc=; h=Date:From:To:Subject:In-Reply-To:From; b=IQqJeE1Ah8Iz4iJffpBF7JFbANlmkj3/X7P+83X/EPxdIywlhzBFVV/zvA/GK1r1a 1Po52uWrFqCHYAHgPuHkkc36fMkAxUa6MWb2iZaVuONcOJuk1QMvFa0vlT2i6+FOgf 5BQgCHh233yFtOxVkDq7dsKn6p4odjLVUbVF7gK4= Date: Tue, 09 Feb 2021 13:42:36 -0800 From: Andrew Morton To: akpm@linux-foundation.org, joachim.henke@t-systems.com, konishi.ryusuke@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 14/14] nilfs2: make splice write available again Message-ID: <20210209214236.pDQfcjKyd%akpm@linux-foundation.org> In-Reply-To: <20210209134115.4d933d446165cd0ed8977b03@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Joachim Henke Subject: nilfs2: make splice write available again Since 5.10, splice() or sendfile() to NILFS2 return EINVAL. This was caused by commit 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops"). This patch initializes the splice_write field in file_operations, like most file systems do, to restore the functionality. Link: https://lkml.kernel.org/r/1612784101-14353-1-git-send-email-konishi.ryusuke@gmail.com Signed-off-by: Joachim Henke Signed-off-by: Ryusuke Konishi Tested-by: Ryusuke Konishi Cc: [5.10+] Signed-off-by: Andrew Morton --- fs/nilfs2/file.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/nilfs2/file.c~nilfs2-make-splice-write-available-again +++ a/fs/nilfs2/file.c @@ -141,6 +141,7 @@ const struct file_operations nilfs_file_ /* .release = nilfs_release_file, */ .fsync = nilfs_sync_file, .splice_read = generic_file_splice_read, + .splice_write = iter_file_splice_write, }; const struct inode_operations nilfs_file_inode_operations = { _