From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B4D4C433E0 for ; Mon, 8 Feb 2021 17:26:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5398064E5A for ; Mon, 8 Feb 2021 17:26:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5398064E5A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8FAFE6B0006; Mon, 8 Feb 2021 12:26:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AB246B006C; Mon, 8 Feb 2021 12:26:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C0F76B006E; Mon, 8 Feb 2021 12:26:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 660506B0006 for ; Mon, 8 Feb 2021 12:26:42 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 29DC68248047 for ; Mon, 8 Feb 2021 17:26:42 +0000 (UTC) X-FDA: 77795780244.11.space01_6106ec427600 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 0B6E0183459D8 for ; Mon, 8 Feb 2021 17:26:42 +0000 (UTC) X-HE-Tag: space01_6106ec427600 X-Filterd-Recvd-Size: 2198 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 17:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ke1hxt0FRH7sV6bLaq9pHrT4cON6Sd9F2qPDMzZG7NI=; b=TwoTO4rvqglLPbU0a10zOrdEFi ETZHslKkqFVfe/ub6DERrZhVSXQQh0/TbAdhIjrUF/mwALGrnZCf0hkvVlcalQFFIQElif+GGRpqX mE1nkjHKru1zEOmwK7WjkklN/hk6GJtCCB8E476lhyHyH+kksvtD7DpNdpBRDfOZgF2YnUCPJ/t26 G7E39ADHWpHDC+1dXa2/ikcvBUwF+fEBUgtDyJrAOntZ5tv9tELDhT7EbZ7/wUIi1Wko7ldTppHn0 3AFPXoh3ss+QGtJmHOQfF7HaDi9RBnUnluR/Qb2WwwvVgeEnvbNsS12Od0FnayqCnc+bUGJc5Kwgs 3Veb73wA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l9AIS-006HH7-U4; Mon, 08 Feb 2021 17:26:01 +0000 Date: Mon, 8 Feb 2021 17:26:00 +0000 From: Matthew Wilcox To: Yafang Shao Cc: andriy.shevchenko@linux.intel.com, david@redhat.com, vbabka@suse.cz, cl@linux.com, linmiaohe@huawei.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, joe@perches.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO Message-ID: <20210208172600.GU308988@casper.infradead.org> References: <20210208101439.55474-1-laoar.shao@gmail.com> <20210208101439.55474-3-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208101439.55474-3-laoar.shao@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 08, 2021 at 06:14:38PM +0800, Yafang Shao wrote: > It is strange to combine "pr_err" with "INFO", so let's remove the > prefix completely. So is this the right thing to do? Should it be pr_info() instead? Many of these messages do not appear to be error messages, but rather informational messages.