From: Andrew Morton <akpm@linux-foundation.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Huang Pei <huangpei@loongson.cn>,
ambrosehua@gmail.com, Bibo Mao <maobibo@loongson.cn>,
linux-mips@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Paul Burton <paulburton@kernel.org>,
Li Xuefeng <lixuefeng@loongson.cn>,
Yang Tiezhu <yangtiezhu@loongson.cn>,
Gao Juxin <gaojuxin@loongson.cn>,
Fuxin Zhang <zhangfx@lemote.com>, Huacai Chen <chenhc@lemote.com>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH] MIPS: make userspace mapping young by default
Date: Mon, 8 Feb 2021 11:48:56 -0800 [thread overview]
Message-ID: <20210208114856.e8062823b2e84e1adb1d59bb@linux-foundation.org> (raw)
In-Reply-To: <30b3fcb5-a60d-228f-15d2-cd182953de45@csgroup.eu>
On Mon, 8 Feb 2021 18:44:22 +0100 Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
>
>
> Le 06/02/2021 à 00:41, Andrew Morton a écrit :
> > On Thu, 4 Feb 2021 16:22:39 +0100 Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:
> >
> >> On Thu, Feb 04, 2021 at 09:39:42AM +0800, Huang Pei wrote:
> >>> MIPS page fault path(except huge page) takes 3 exceptions (1 TLB Miss
> >>> + 2 TLB Invalid), butthe second TLB Invalid exception is just
> >>> triggered by __update_tlb from do_page_fault writing tlb without
> >>> _PAGE_VALID set. With this patch, user space mapping prot is made
> >>> young by default (with both _PAGE_VALID and _PAGE_YOUNG set),
> >>> and it only take 1 TLB Miss + 1 TLB Invalid exception
> >>>
> >>> Remove pte_sw_mkyoung without polluting MM code and make page fault
> >>> delay of MIPS on par with other architecture
> >>>
> >>> Signed-off-by: Huang Pei <huangpei@loongson.cn>
> >>> ---
> >>> arch/mips/mm/cache.c | 30 ++++++++++++++++--------------
> >>> include/linux/pgtable.h | 8 --------
> >>> mm/memory.c | 3 ---
> >>> 3 files changed, 16 insertions(+), 25 deletions(-)
> >>
> >> Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> >>
> >> Andrew, can you take this patch through your tree ?
> >
> > Sure. I'll drop Christophe's "mm/memory.c: remove pte_sw_mkyoung()"
> > (https://lkml.kernel.org/r/f302ef92c48d1f08a0459aaee1c568ca11213814.1612345700.git.christophe.leroy@csgroup.eu)
> > in favour of this one.
> >
>
> Pitty. My patch was improving page faults on powerpc/32.
How does it do that? By running pte_mkyoung() for powerpc32? Such a
change is still valid, isn't it?
> That one is only addressing MIPS.
It cleans up core code nicely, by removing a MIPS wart. We can still
add a ppc32 wart?
>
> Any plan to take the series from Nick
> https://patchwork.kernel.org/project/linux-mm/list/?series=404539 ?
I expect so. After -rc1, if the churn is settling down and reviewers
are happy enough.
next prev parent reply other threads:[~2021-02-08 19:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 1:39 Huang Pei
2021-02-04 3:29 ` Nicholas Piggin
2021-02-04 4:46 ` 黄沛
2021-02-04 10:34 ` Thomas Bogendoerfer
2021-02-04 11:27 ` Nicholas Piggin
2021-02-04 15:22 ` Thomas Bogendoerfer
2021-02-05 23:41 ` Andrew Morton
2021-02-08 17:44 ` Christophe Leroy
2021-02-08 19:48 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-19 7:39 Huang Pei
2020-09-04 8:49 Huang Pei
2020-09-07 8:50 ` maobibo
2020-09-07 10:35 ` Huang Pei
2020-09-07 13:10 ` maobibo
2020-07-26 8:32 [PATCH v2 1/2] MIPS: Set page access bit with pgprot on platforms with RIXI Thomas Bogendoerfer
2020-08-25 3:20 ` [PATCH v2 1/2] MIPS: Set page access bit with pgprot on Huang Pei
2020-08-25 3:20 ` [PATCH] MIPS: make userspace mapping young by default Huang Pei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208114856.e8062823b2e84e1adb1d59bb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ambrosehua@gmail.com \
--cc=chenhc@lemote.com \
--cc=christophe.leroy@csgroup.eu \
--cc=gaojuxin@loongson.cn \
--cc=huangpei@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixuefeng@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=npiggin@gmail.com \
--cc=paulburton@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox