From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40D7C433E0 for ; Sun, 7 Feb 2021 15:31:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E64864D9D for ; Sun, 7 Feb 2021 15:31:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E64864D9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B2286B0006; Sun, 7 Feb 2021 10:31:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 761DC6B006C; Sun, 7 Feb 2021 10:31:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 650A06B006E; Sun, 7 Feb 2021 10:31:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 52AE16B0006 for ; Sun, 7 Feb 2021 10:31:39 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1B32B180AD811 for ; Sun, 7 Feb 2021 15:31:39 +0000 (UTC) X-FDA: 77791861518.21.blade26_350f8e2275f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id F2804180442C0 for ; Sun, 7 Feb 2021 15:31:38 +0000 (UTC) X-HE-Tag: blade26_350f8e2275f7 X-Filterd-Recvd-Size: 5335 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Sun, 7 Feb 2021 15:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612711897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O9wMc0Nwk/ptxsKes013Q7zDZE4xfkXHgPlyBiz6rcU=; b=U/vplX39cWR1BDLVeg1Wmn6rngtYmSkV90L8zrW9Z6TbpPvIoGLTHLoSSjTajFhsg+c9xP uYod3DGMadR29XuVToOGoxOuCy8FWOZ8J6R62K6iSkYKI0JzJpE9zo5DDJNjtD0khzG/YZ 8yLE9VDVga86rwn6VvcBVUpcUuJ/VoQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382--21XNCrcPuqzmZ3LF4WvmA-1; Sun, 07 Feb 2021 10:31:34 -0500 X-MC-Unique: -21XNCrcPuqzmZ3LF4WvmA-1 Received: by mail-qk1-f197.google.com with SMTP id m64so10614606qke.12 for ; Sun, 07 Feb 2021 07:31:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=O9wMc0Nwk/ptxsKes013Q7zDZE4xfkXHgPlyBiz6rcU=; b=C1ctBb+IgUpsHiLG+rrkuTG+rOPHUusLkFGV9fUf8DsjIXq4W8VIphMGgs7Lt4U4NI J/y54HKXJzfrgRDUePfD4kkeQx/dXiVrBgj1XtSv4fNFshW1IWHNVkstIg18WkiRi1Ng Ve3N8Xrq2Zdzb7VDBiF/s0lawWv7KzihYKYbQSe2dWvRAw9oomHt7SKyWnXh/9WgIUkT Sh359NXdUSqX2e3tLyZlXlZ2NAexlkBTkUv593EtxTyPZyBsfmMIeMGXUV8LWv1c5gLZ a+B/4q9ZSX7NDI30tbKWDOxdLe174XxdweVOoJHcua+pqscuVLaVUc52icHELWEq5jRP CnhA== X-Gm-Message-State: AOAM5306HHjicOkKKYwDdz1Tv++WSLetneC9clenjMalvexM8HODwPPU TZLWo4KEOrKJt92YHx/y3TWW03Q2ul/FAgH8ic8qVWQgA6YqEWbVb/+PMiaXcEh6CtSi42k2mDv W8vK7JWEM5+s= X-Received: by 2002:ad4:4f83:: with SMTP id em3mr12578858qvb.28.1612711893549; Sun, 07 Feb 2021 07:31:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZa3e25KJ1KDCo+IfZwNJ1A6Dcdg67juAmeKNVHXNzDBavVj6TePsRdVWpAD5Xav7+h5elSQ== X-Received: by 2002:ad4:4f83:: with SMTP id em3mr12578837qvb.28.1612711893328; Sun, 07 Feb 2021 07:31:33 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-182.dsl.bell.ca. [174.93.89.182]) by smtp.gmail.com with ESMTPSA id j124sm14143814qkf.113.2021.02.07.07.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 07:31:32 -0800 (PST) Date: Sun, 7 Feb 2021 10:31:30 -0500 From: Peter Xu To: Gal Pressman Cc: "Zhang, Wei" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Kirill Shutemov , Mike Rapoport , Matthew Wilcox , Miaohe Lin , Andrea Arcangeli , Jan Kara , Jann Horn , Andrew Morton , Kirill Tkhai , Linus Torvalds , Mike Kravetz , Jason Gunthorpe , David Gibson , Christoph Hellwig Subject: Re: [PATCH v2 4/4] hugetlb: Do early cow when page pinned on src mm Message-ID: <20210207153130.GH3195@xz-x1> References: <20210204145033.136755-1-peterx@redhat.com> <20210204145033.136755-5-peterx@redhat.com> <329ADC08-552E-423B-9230-99643B81C14A@amazon.com> <20210205155114.GY6468@xz-x1> <10d5cdce-4748-1b9e-b433-6f3d1bde63db@amazon.com> MIME-Version: 1.0 In-Reply-To: <10d5cdce-4748-1b9e-b433-6f3d1bde63db@amazon.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000119, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 07, 2021 at 11:09:29AM +0200, Gal Pressman wrote: > On 05/02/2021 17:51, Peter Xu wrote: > > On Fri, Feb 05, 2021 at 02:58:33PM +0000, Zhang, Wei wrote: > >> Hi Peter, > >=20 > > Hi, Wei, > >=20 > >> > >> Gal and I worked together. We tested the patch v2 and can confirm it= is working as intended. > >> > >> Thank you very much for your quick response! > >=20 > > My thanks too on the quick testing! Sorry that I'll need to post v3;= please > > feel free to hold off the testing until I got some r-bs with the new = version. >=20 > BTW, it might already be fixed in v3, but I encountered a compilation w= arning > with this series: >=20 > mm/memory.c: In function =E2=80=98copy_present_page=E2=80=99: > mm/memory.c:800:20: warning: unused variable =E2=80=98src_mm=E2=80=99 [= -Wunused-variable] > struct mm_struct *src_mm =3D src_vma->vm_mm; > ^~~~~~ Not yet, thanks for raising this, Gal. I'll wait for some more review fe= edback on v3 and send a new version with it fixed. --=20 Peter Xu