From: Andrew Morton <akpm@linux-foundation.org>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Hugh Dickins <hughd@google.com>,
Chris Down <chris@chrisdown.name>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tmpfs: Don't use 64-bit inodes by defulat with 32-bit ino_t
Date: Fri, 5 Feb 2021 12:41:57 -0800 [thread overview]
Message-ID: <20210205124157.c9d855a373362d7bf3d811a7@linux-foundation.org> (raw)
In-Reply-To: <20210205202159.505612-1-seth.forshee@canonical.com>
On Fri, 5 Feb 2021 14:21:59 -0600 Seth Forshee <seth.forshee@canonical.com> wrote:
> Currently there seems to be an assumption in tmpfs that 64-bit
> architectures also have a 64-bit ino_t. This is not true; s390 at
> least has a 32-bit ino_t. With CONFIG_TMPFS_INODE64=y tmpfs
> mounts will get 64-bit inode numbers and display "inode64" in the
> mount options, but passing the "inode64" mount option will fail.
> This leads to the following behavior:
>
> # mkdir mnt
> # mount -t tmpfs nodev mnt
> # mount -o remount,rw mnt
> mount: /home/ubuntu/mnt: mount point not mounted or bad option.
>
> As mount sees "inode64" in the mount options and thus passes it
> in the options for the remount.
>
> Ideally CONFIG_TMPFS_INODE64 would depend on sizeof(ino_t) < 8,
> but I don't think it's possible to test for this (potentially
> CONFIG_ARCH_HAS_64BIT_INO_T or similar could be added, but I'm
> not sure whether or not that is wanted). So fix this by simply
> refusing to honor the CONFIG_TMPFS_INODE64 setting when
> sizeof(ino_t) < 8.
How about changing s390 Kconfig so that CONFIG_TMPFS_INODE64 is not enabled?
> Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb")
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
With a cc:stable, I assume?
next prev parent reply other threads:[~2021-02-05 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 20:21 Seth Forshee
2021-02-05 20:41 ` Andrew Morton [this message]
2021-02-05 20:55 ` Seth Forshee
2021-02-05 21:23 ` Andrew Morton
2021-02-05 21:32 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205124157.c9d855a373362d7bf3d811a7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox