From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 384D7C433DB for ; Thu, 4 Feb 2021 15:01:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B42A664F42 for ; Thu, 4 Feb 2021 15:01:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B42A664F42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 464E76B0006; Thu, 4 Feb 2021 10:01:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 415586B006C; Thu, 4 Feb 2021 10:01:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32C3B6B0070; Thu, 4 Feb 2021 10:01:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 1A84F6B0006 for ; Thu, 4 Feb 2021 10:01:10 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 730A53489 for ; Thu, 4 Feb 2021 15:01:09 +0000 (UTC) X-FDA: 77780898258.08.woman95_1c07177275dd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 5AA411819E76F for ; Thu, 4 Feb 2021 15:01:09 +0000 (UTC) X-HE-Tag: woman95_1c07177275dd X-Filterd-Recvd-Size: 4960 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Feb 2021 15:01:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F1F364DBA; Thu, 4 Feb 2021 15:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612450867; bh=X3nDmJLqqvOAm1bXasPKKjZSRX+UA/YVvHhs0nTd4PE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mg4bHqG1JiGD+kFpfyB7KEAJYbxncHFMReA4zfD++ymeCwsVKBWNIfoI4buqLZUoJ ohLIbTf2EidP0Mxo2YG6rqVGliuVwtlOAoRbQK4nJPtXk7zg7q0166rsx3lGydAqoC U2UoZ6WXgGwJ+HYL/oAmzNDtkyryGVFypiM5sGtafFhTCpok9WYOn4IA1VKGyI46W9 WO8/IItQpXGt02EujFUGVoU3orj4aRW/ERrrwvCuDWssqzDE/5/DK/Ba99eunJbxnC DINnx62rYn9eMMFfhELFw+UDZgfcz5J4l3i1Lm8sTdjnLkMGnaYoWpFMOSfcoFjunr Xx4S47isXTL2w== Date: Thu, 4 Feb 2021 15:01:01 +0000 From: Will Deacon To: Lecopzer Chen Cc: akpm@linux-foundation.org, andreyknvl@google.com, ardb@kernel.org, aryabinin@virtuozzo.com, broonie@kernel.org, catalin.marinas@arm.com, dan.j.williams@intel.com, dvyukov@google.com, glider@google.com, gustavoars@kernel.org, kasan-dev@googlegroups.com, lecopzer.chen@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org, linux@roeck-us.net, robin.murphy@arm.com, rppt@kernel.org, tyhicks@linux.microsoft.com, vincenzo.frascino@arm.com, yj.chiang@mediatek.com Subject: Re: [PATCH v2 1/4] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC Message-ID: <20210204150100.GE20815@willie-the-truck> References: <20210204124543.GA20468@willie-the-truck> <20210204144612.75582-1-lecopzer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204144612.75582-1-lecopzer@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 04, 2021 at 10:46:12PM +0800, Lecopzer Chen wrote: > > On Sat, Jan 09, 2021 at 06:32:49PM +0800, Lecopzer Chen wrote: > > > Linux support KAsan for VMALLOC since commit 3c5c3cfb9ef4da9 > > > ("kasan: support backing vmalloc space with real shadow memory") > > > > > > Like how the MODULES_VADDR does now, just not to early populate > > > the VMALLOC_START between VMALLOC_END. > > > similarly, the kernel code mapping is now in the VMALLOC area and > > > should keep these area populated. > > > > > > Signed-off-by: Lecopzer Chen > > > --- > > > arch/arm64/mm/kasan_init.c | 23 ++++++++++++++++++----- > > > 1 file changed, 18 insertions(+), 5 deletions(-) > > > > > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > > > index d8e66c78440e..39b218a64279 100644 > > > --- a/arch/arm64/mm/kasan_init.c > > > +++ b/arch/arm64/mm/kasan_init.c > > > @@ -214,6 +214,7 @@ static void __init kasan_init_shadow(void) > > > { > > > u64 kimg_shadow_start, kimg_shadow_end; > > > u64 mod_shadow_start, mod_shadow_end; > > > + u64 vmalloc_shadow_start, vmalloc_shadow_end; > > > phys_addr_t pa_start, pa_end; > > > u64 i; > > > > > > @@ -223,6 +224,9 @@ static void __init kasan_init_shadow(void) > > > mod_shadow_start = (u64)kasan_mem_to_shadow((void *)MODULES_VADDR); > > > mod_shadow_end = (u64)kasan_mem_to_shadow((void *)MODULES_END); > > > > > > + vmalloc_shadow_start = (u64)kasan_mem_to_shadow((void *)VMALLOC_START); > > > + vmalloc_shadow_end = (u64)kasan_mem_to_shadow((void *)VMALLOC_END); > > > + > > > /* > > > * We are going to perform proper setup of shadow memory. > > > * At first we should unmap early shadow (clear_pgds() call below). > > > @@ -241,12 +245,21 @@ static void __init kasan_init_shadow(void) > > > > > > kasan_populate_early_shadow(kasan_mem_to_shadow((void *)PAGE_END), > > > (void *)mod_shadow_start); > > > - kasan_populate_early_shadow((void *)kimg_shadow_end, > > > - (void *)KASAN_SHADOW_END); > > > + if (IS_ENABLED(CONFIG_KASAN_VMALLOC)) { > > > > Do we really need yet another CONFIG option for KASAN? What's the use-case > > for *not* enabling this if you're already enabling one of the KASAN > > backends? > > As I know, KASAN_VMALLOC now only supports KASAN_GENERIC and also > KASAN_VMALLOC uses more memory to map real shadow memory (1/8 of vmalloc va). The shadow is allocated dynamically though, isn't it? > There should be someone can enable KASAN_GENERIC but can't use VMALLOC > due to memory issue. That doesn't sound particularly realistic to me. The reason I'm pushing here is because I would _really_ like to move to VMAP stack unconditionally, and that would effectively force KASAN_VMALLOC to be set if KASAN is in use. So unless there's a really good reason not to do that, please can we make this unconditional for arm64? Pretty please? Will