From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DB3C433E0 for ; Thu, 4 Feb 2021 12:38:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 383C564F3F for ; Thu, 4 Feb 2021 12:38:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 383C564F3F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B33F66B0005; Thu, 4 Feb 2021 07:38:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE44E6B006E; Thu, 4 Feb 2021 07:38:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FA4C6B0070; Thu, 4 Feb 2021 07:38:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 8790A6B0005 for ; Thu, 4 Feb 2021 07:38:19 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4B21A181AC9C6 for ; Thu, 4 Feb 2021 12:38:19 +0000 (UTC) X-FDA: 77780538318.02.gold98_40007c3275dc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 2413210097AA1 for ; Thu, 4 Feb 2021 12:38:19 +0000 (UTC) X-HE-Tag: gold98_40007c3275dc X-Filterd-Recvd-Size: 2046 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Feb 2021 12:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NjY5liFAlk+AQiAuqlneZkVZMjMxiky/Okh0XWtNNUY=; b=jgQNlr2Asr/peAmVBvLbuI7Zzm 4YECc6L6RVdMJjBfC3gzUjus9oPzwhHkzLpTn2cA0/8Ad/zo6dZJzex3IuV8Cl4dWuuF/BfDY0esw 1xDtrS72MXJdeTM+5/TCW4viT0iqy3BVBff/BIkD9O9eZF0d5NBVal28pKbkrVAtutf0XcAUVsQK+ 0PnN1rNWW4vPz3jO1799PTL3Dr2Wii5K7FLmo4FLBSlubTjAv4A81LHGS+DSLwngZoiVmMmKJ/yx6 b0AQarcu1Je4J48SNyDmcNBjSgWL9O8UBT1+EtDyi18yfBjVBVeC80yfmPOgjNS4wN1oIEHBhyQy5 ajN7Zj3A==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l7dtf-000rrw-Rc; Thu, 04 Feb 2021 12:38:09 +0000 Date: Thu, 4 Feb 2021 12:38:07 +0000 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/rmap: Correct obsolete comment of page_get_anon_vma() Message-ID: <20210204123807.GE308988@casper.infradead.org> References: <20210203093215.31990-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203093215.31990-1-linmiaohe@huawei.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 03, 2021 at 04:32:15AM -0500, Miaohe Lin wrote: > * Since there is no serialization what so ever against page_remove_rmap() > - * the best this function can do is return a locked anon_vma that might > - * have been relevant to this page. > + * the best this function can do is return a refcount increased anon_vma > + * that might have been relevant to this page. Just s/a locked/an/ there's no need to mention again that the refcount is increased.