From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FD7C433E0 for ; Thu, 4 Feb 2021 20:24:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 07F4264F48 for ; Thu, 4 Feb 2021 20:24:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07F4264F48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4E4466B0005; Thu, 4 Feb 2021 15:24:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 46DE16B0006; Thu, 4 Feb 2021 15:24:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 338EA6B006E; Thu, 4 Feb 2021 15:24:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id 166F16B0005 for ; Thu, 4 Feb 2021 15:24:13 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D6831180AD80F for ; Thu, 4 Feb 2021 20:24:12 +0000 (UTC) X-FDA: 77781712344.13.prose48_0e00d0d275df Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id BC35118140B69 for ; Thu, 4 Feb 2021 20:24:12 +0000 (UTC) X-HE-Tag: prose48_0e00d0d275df X-Filterd-Recvd-Size: 4458 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Feb 2021 20:24:12 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id g15so2487910pjd.2 for ; Thu, 04 Feb 2021 12:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YiBh8kjoQsH+w1ie1OfB7U+mi5FxxL8KWnwrDiJ80SQ=; b=PPt+H4wqt1A6KWRSkPhPkxwMn/vw3TKT91vvsKmHebL+0nltYCjD9IrFeHTRAjQymj BUG3q3cW2DBZiH22qiC37rSeMW4mlApOQfqnOR82W1zU+j/au6dXILhqYy9A8+6Iv8qY bcd9AfXep4kZgB1Vmchd6yJteQKwVnKD37aR4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YiBh8kjoQsH+w1ie1OfB7U+mi5FxxL8KWnwrDiJ80SQ=; b=kwA/zh5L/3Jl/fqPh8ZHo02NsodGMS6syIfv2/Sius533xGxxv7jsrd9TcWGIWMzUm leNdkOSsDgv18iWMVayvO9yHv8W8Pl4LnDXzOBbXd7wAmm89Y4D6F6ge6SrxvgnMaRu7 6BSRCAp8/YGAUSlLmswIYZMK6IFBbGtlyn3iHTNycTBy8ibxWWoXCUI3s48pi9eNxrcl fWfLP1JhyaxtvOV1ZB8fANIpVJJWRdy0mAah8Z94ZJJB5/vHfNDNoas82wBPqdByBbxr QyA9n8ZD/XX/CufxFnVzIbGy7+5Hu2ITAtBEWLADwYZZHOvHlnKqOjrksZdaeLOHKDya eJag== X-Gm-Message-State: AOAM532HKtGVD1hPfXTTOUGkyhBAZKI34wIF7brXaFKiwURuWM4L2hWL zyGSf0XXUqqRmJ+oskTYSd1OTg== X-Google-Smtp-Source: ABdhPJw0Vm+wT2LUNwph4uBXmL08ISQPaD4Ai/QvO5oPqXHsNDkCcUZJ728ruOrlMF1dvvaBvhbAXQ== X-Received: by 2002:a17:902:59dc:b029:e2:9e80:1537 with SMTP id d28-20020a17090259dcb02900e29e801537mr954553plj.66.1612470251540; Thu, 04 Feb 2021 12:24:11 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k11sm6241168pfc.22.2021.02.04.12.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 12:24:10 -0800 (PST) Date: Thu, 4 Feb 2021 12:24:09 -0800 From: Kees Cook To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu Subject: Re: [PATCH v19 16/25] mm: Add guard pages around a shadow stack. Message-ID: <202102041224.5D300A122B@keescook> References: <20210203225547.32221-1-yu-cheng.yu@intel.com> <20210203225547.32221-17-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203225547.32221-17-yu-cheng.yu@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 03, 2021 at 02:55:38PM -0800, Yu-cheng Yu wrote: > INCSSP(Q/D) increments shadow stack pointer and 'pops and discards' the > first and the last elements in the range, effectively touches those memory > areas. > > The maximum moving distance by INCSSPQ is 255 * 8 = 2040 bytes and > 255 * 4 = 1020 bytes by INCSSPD. Both ranges are far from PAGE_SIZE. > Thus, putting a gap page on both ends of a shadow stack prevents INCSSP, > CALL, and RET from going beyond. > > Signed-off-by: Yu-cheng Yu Yay guard pages! :) Reviewed-by: Kees Cook -- Kees Cook