From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E082AC433E0 for ; Thu, 4 Feb 2021 10:37:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB28564F4D for ; Thu, 4 Feb 2021 10:37:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB28564F4D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1C0DA6B0005; Thu, 4 Feb 2021 05:37:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 173536B006E; Thu, 4 Feb 2021 05:37:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 088E36B0070; Thu, 4 Feb 2021 05:37:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id E50D66B0005 for ; Thu, 4 Feb 2021 05:37:28 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9DEA4180AD820 for ; Thu, 4 Feb 2021 10:37:28 +0000 (UTC) X-FDA: 77780233776.19.bomb21_48053d5275db Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 7A6711AD1B0 for ; Thu, 4 Feb 2021 10:37:28 +0000 (UTC) X-HE-Tag: bomb21_48053d5275db X-Filterd-Recvd-Size: 2476 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Feb 2021 10:37:27 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l7c0m-0002Oa-00; Thu, 04 Feb 2021 11:37:20 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id DF6BFC0D52; Thu, 4 Feb 2021 11:34:59 +0100 (CET) Date: Thu, 4 Feb 2021 11:34:59 +0100 From: Thomas Bogendoerfer To: Nicholas Piggin Cc: ambrosehua@gmail.com, Huang Pei , Andrew Morton , Huacai Chen , Gao Juxin , Jiaxun Yang , linux-arch@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, Li Xuefeng , Bibo Mao , Paul Burton , Yang Tiezhu , Fuxin Zhang Subject: Re: [PATCH] MIPS: make userspace mapping young by default Message-ID: <20210204103459.GA10558@alpha.franken.de> References: <20210204013942.8398-1-huangpei@loongson.cn> <1612409285.q4gi3x2bhk.astroid@bobo.none> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1612409285.q4gi3x2bhk.astroid@bobo.none> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.002224, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 04, 2021 at 01:29:26PM +1000, Nicholas Piggin wrote: > Excerpts from Huang Pei's message of February 4, 2021 11:39 am: > > MIPS page fault path(except huge page) takes 3 exceptions (1 TLB Miss > > + 2 TLB Invalid), butthe second TLB Invalid exception is just > > triggered by __update_tlb from do_page_fault writing tlb without > > _PAGE_VALID set. With this patch, user space mapping prot is made > > young by default (with both _PAGE_VALID and _PAGE_YOUNG set), > > and it only take 1 TLB Miss + 1 TLB Invalid exception > > > > Remove pte_sw_mkyoung without polluting MM code and make page fault > > delay of MIPS on par with other architecture > > > > Signed-off-by: Huang Pei > > Could we merge this? For the core code, sure, but IMHO I should only merge the MIPS part, correct ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]