From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AED2C433E0 for ; Wed, 3 Feb 2021 17:21:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B204564DDB for ; Wed, 3 Feb 2021 17:21:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B204564DDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3FCF16B007D; Wed, 3 Feb 2021 12:21:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35F2E6B007E; Wed, 3 Feb 2021 12:21:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 166A46B0080; Wed, 3 Feb 2021 12:21:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id F05146B007D for ; Wed, 3 Feb 2021 12:21:35 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B7B07824999B for ; Wed, 3 Feb 2021 17:21:35 +0000 (UTC) X-FDA: 77777623350.28.brake63_1d0ece5275d5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 7B7E76C21 for ; Wed, 3 Feb 2021 17:21:35 +0000 (UTC) X-HE-Tag: brake63_1d0ece5275d5 X-Filterd-Recvd-Size: 6090 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Feb 2021 17:21:34 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id z21so192093pgj.4 for ; Wed, 03 Feb 2021 09:21:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WjCWNWtT0pxxhAlETV2zIWjv0Gl4p3lxrm3/RhLgkFI=; b=WOTROWby4+O9mii6I9VKEbRf1e0JneRRZWuOzB+sxeZyY83rimGnXwHvmaiAJl950J UC1zbSHRcY3mTA7B7y5OXXYbolcIsJvey4DCBh5Rx9c8WPmcnqZ8EoMX7SoBo1/dBquC tR1gRLP/wJVJIFcmMJeEliFw3zJ+c6urFzhFbDBrToGBAXbPykkH8hZXQzmV8T5PwuOV ZTYQ445OhWUCveVh+i5qqcAGuex8IQZuctk9F/8j9ZQF2vUTFLPiSFOGi51pyiuqTTet 1cWjwGBAO9noeYyjswJyg79dR8Ck0twVz5IdcPGwpVR02yX8Xg1W8CbhBOQe0PhHS1mv Occg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WjCWNWtT0pxxhAlETV2zIWjv0Gl4p3lxrm3/RhLgkFI=; b=Kj1w8WhXtNXYcG9dqVWVN5IDLZChZ0umdoiQgs65dklQ5GMU+U/h/KyOdwBx8FWY/n ysNJNPWcI2x0qQGKGHXssxqs5B5dWOMuenh1krlKR4UT9450aEZNQqRNe+PNg5u/NvW3 MOyWfuNpQgcpJrk8tprY5gxaeyKkaSq2N1xLt9aNYynIpoOJhrpzLw7d9BGhb+yyXen4 Y/okZvOUCQb5IBqJ0P5wHEz+eTtxzXqP3fs7x0F8Xz8yBLbqj4J6YEj2yBYrtzdHr19m Rc2x9O6MAYAhNM7XBFraTJIGuumZjDzWToHmg35Crm6mXT5HwmShe6Lf0jYJY6pDp9L4 YUbg== X-Gm-Message-State: AOAM530R5G7kGY/uy+luW1xVTFsM+lWaF9UfMwRG7na5gCREBnK4nc29 798ORNbnMYF8zlHZbtlTtiVvOuS5iVUoBw== X-Google-Smtp-Source: ABdhPJzqcaYYDKlp3sUAGpXDR3SSEmVgbvV1MQeGqx85pwWP5dg6r1K9s1IWZLx1A1HO79RYXirMpQ== X-Received: by 2002:a62:760b:0:b029:1b6:3897:3f86 with SMTP id r11-20020a62760b0000b02901b638973f86mr3803216pfc.24.1612372894244; Wed, 03 Feb 2021 09:21:34 -0800 (PST) Received: from localhost.localdomain (c-73-93-239-127.hsd1.ca.comcast.net. [73.93.239.127]) by smtp.gmail.com with ESMTPSA id x21sm2368636pfn.100.2021.02.03.09.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 09:21:32 -0800 (PST) From: Yang Shi To: guro@fb.com, ktkhai@virtuozzo.com, vbabka@suse.cz, shakeelb@google.com, david@fromorbit.com, hannes@cmpxchg.org, mhocko@suse.com, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v6 PATCH 11/11] mm: vmscan: shrink deferred objects proportional to priority Date: Wed, 3 Feb 2021 09:20:42 -0800 Message-Id: <20210203172042.800474-12-shy828301@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210203172042.800474-1-shy828301@gmail.com> References: <20210203172042.800474-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The number of deferred objects might get windup to an absurd number, and = it results in clamp of slab objects. It is undesirable for sustaining worki= ngset. So shrink deferred objects proportional to priority and cap nr_deferred t= o twice of cache items. The idea is borrowed fron Dave Chinner's patch: https://lore.kernel.org/linux-xfs/20191031234618.15403-13-david@fromorbit= .com/ Tested with kernel build and vfs metadata heavy workload in our productio= n environment, no regression is spotted so far. Signed-off-by: Yang Shi --- mm/vmscan.c | 40 +++++----------------------------------- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 574d920c4cab..d0a86170854b 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -649,7 +649,6 @@ static unsigned long do_shrink_slab(struct shrink_con= trol *shrinkctl, */ nr =3D count_nr_deferred(shrinker, shrinkctl); =20 - total_scan =3D nr; if (shrinker->seeks) { delta =3D freeable >> priority; delta *=3D 4; @@ -663,37 +662,9 @@ static unsigned long do_shrink_slab(struct shrink_co= ntrol *shrinkctl, delta =3D freeable / 2; } =20 + total_scan =3D nr >> priority; total_scan +=3D delta; - if (total_scan < 0) { - pr_err("shrink_slab: %pS negative objects to delete nr=3D%ld\n", - shrinker->scan_objects, total_scan); - total_scan =3D freeable; - next_deferred =3D nr; - } else - next_deferred =3D total_scan; - - /* - * We need to avoid excessive windup on filesystem shrinkers - * due to large numbers of GFP_NOFS allocations causing the - * shrinkers to return -1 all the time. This results in a large - * nr being built up so when a shrink that can do some work - * comes along it empties the entire cache due to nr >>> - * freeable. This is bad for sustaining a working set in - * memory. - * - * Hence only allow the shrinker to scan the entire cache when - * a large delta change is calculated directly. - */ - if (delta < freeable / 4) - total_scan =3D min(total_scan, freeable / 2); - - /* - * Avoid risking looping forever due to too large nr value: - * never try to free more than twice the estimate number of - * freeable entries. - */ - if (total_scan > freeable * 2) - total_scan =3D freeable * 2; + total_scan =3D min(total_scan, (2 * freeable)); =20 trace_mm_shrink_slab_start(shrinker, shrinkctl, nr, freeable, delta, total_scan, priority); @@ -732,10 +703,9 @@ static unsigned long do_shrink_slab(struct shrink_co= ntrol *shrinkctl, cond_resched(); } =20 - if (next_deferred >=3D scanned) - next_deferred -=3D scanned; - else - next_deferred =3D 0; + next_deferred =3D max_t(long, (nr - scanned), 0) + total_scan; + next_deferred =3D min(next_deferred, (2 * freeable)); + /* * move the unused scan count back into the shrinker in a * manner that handles concurrent updates. --=20 2.26.2