From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 118B6C433E0 for ; Tue, 2 Feb 2021 13:13:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD60B64EDB for ; Tue, 2 Feb 2021 13:13:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD60B64EDB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=pm.me Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2FBE46B0005; Tue, 2 Feb 2021 08:13:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AC776B006C; Tue, 2 Feb 2021 08:13:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EA8A6B006E; Tue, 2 Feb 2021 08:13:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 0A6336B0005 for ; Tue, 2 Feb 2021 08:13:14 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BB3E33633 for ; Tue, 2 Feb 2021 13:13:13 +0000 (UTC) X-FDA: 77773368666.19.bag84_470f3f6275cb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 943A81AD1B3 for ; Tue, 2 Feb 2021 13:13:13 +0000 (UTC) X-HE-Tag: bag84_470f3f6275cb X-Filterd-Recvd-Size: 3473 Received: from mail2.protonmail.ch (mail2.protonmail.ch [185.70.40.22]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 13:13:12 +0000 (UTC) Date: Tue, 02 Feb 2021 13:13:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1612271590; bh=wkrsDsmJrKMWDTAP0CgzaSOfN+12VWFr81Nb1Qb7W0A=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=K7qCB1jwBd70fF7fnDVz7zwMpJCi3aRlkq6AbbrG0dMIDUTBab250VWxXM7d/JBeC imiSnG9/VbWmDCmxV4UOshgzGyFI06qGkOkjCPKDhepiMo/1oMQeS9oWgXTMs+qyXq D2ICe8QN/OKumGGOm2iLXsg0gHJUVLLbKU7F0CCCuB34jgsQAHDShDBtHlNkHppNNn JIKcB4hwUJDpwYyFakZ7zUnxsauJA8AMVC2iJMU7lT/KMC1WvYnzMj00ZtU0KrPxwN jyS8F0rt7d/4XC1FKuoG9uDC1kT6Fi/OnhzOUUiUB32HwX6pgyjODc3AEFyO2DD82t GQ5im5p3D47HQ== To: Jakub Kicinski From: Alexander Lobakin Cc: Alexander Lobakin , "David S. Miller" , John Hubbard , David Rientjes , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Reply-To: Alexander Lobakin Subject: Re: [PATCH v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage Message-ID: <20210202131233.4180-1-alobakin@pm.me> In-Reply-To: <20210201171835.690558df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20210131120844.7529-1-alobakin@pm.me> <20210201171835.690558df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jakub Kicinski Date: Mon, 1 Feb 2021 17:18:35 -0800 > On Sun, 31 Jan 2021 12:11:16 +0000 Alexander Lobakin wrote: > > page_is_pfmemalloc() is used mostly by networking drivers to test > > if a page can be considered for reusing/recycling. > > It doesn't write anything to the struct page itself, so its sole > > argument can be constified, as well as the first argument of > > skb_propagate_pfmemalloc(). > > In Page Pool core code, it can be simply inlined instead. > > Most of the callers from NIC drivers were just doppelgangers of > > the same condition tests. Derive them into a new common function > > do deduplicate the code. >=20 > Please resend, this did not get into patchwork :/ I suspected it would be so as I got reports about undelivered mails due to unavailability of vger.kernel.org for some reasons Will do. Al