From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1EAC433DB for ; Tue, 2 Feb 2021 11:13:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2628164E06 for ; Tue, 2 Feb 2021 11:13:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2628164E06 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9DE716B006C; Tue, 2 Feb 2021 06:13:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 991216B006E; Tue, 2 Feb 2021 06:13:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87CD66B0071; Tue, 2 Feb 2021 06:13:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 6DCEE6B006C for ; Tue, 2 Feb 2021 06:13:30 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 38BB41EE6 for ; Tue, 2 Feb 2021 11:13:30 +0000 (UTC) X-FDA: 77773066980.04.start36_1705d42275ca Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 07319800CAF1 for ; Tue, 2 Feb 2021 11:13:30 +0000 (UTC) X-HE-Tag: start36_1705d42275ca X-Filterd-Recvd-Size: 3381 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 11:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3j9vOVOCZYCRcd/9oHYQqp9mHmLEYzOeZeVPeCqGHSo=; b=e4n+GEXCFgV3PZ41aiD6Dqw6g o4/Nm9vRF/rykkphyuewQKKaCsvwPjQ7qjDpkSl2rehqrN+HgWejfdEkRcMKFr+PU5t52JWcU0+16 VxaKrqDybMSHpFdQdqnPi2lKQAZLpUzrluIUz/u3AVmjwFaRSiBTOfz8NIo0v3xQQ/0u+pMSwCW0W PJsgCCqfMtuwlQG5WX+FAA8ByzjmaUI3ysryKq/qYtKRzxHRKOPhR6B+pnvHt0ljbpSUh7rcQ7kTp ufQ5KhlgyerqAdZ06+9XIiPICqtXkbEgP/Fc57JZGidmE9JT+In/wMitHA2JS63JAuFRQQVRkiukk p2PQ5Minw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38186) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6tcZ-0004HT-Ki; Tue, 02 Feb 2021 11:13:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l6tcV-0002zg-Gy; Tue, 02 Feb 2021 11:13:19 +0000 Date: Tue, 2 Feb 2021 11:13:19 +0000 From: Russell King - ARM Linux admin To: Nicholas Piggin Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Jonathan Cameron , Christoph Hellwig , Christophe Leroy , Rick Edgecombe , Ding Tianhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v12 01/14] ARM: mm: add missing pud_page define to 2-level page tables Message-ID: <20210202111319.GL1463@shell.armlinux.org.uk> References: <20210202110515.3575274-1-npiggin@gmail.com> <20210202110515.3575274-2-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202110515.3575274-2-npiggin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 02, 2021 at 09:05:02PM +1000, Nicholas Piggin wrote: > diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h > index c02f24400369..d63a5bb6bd0c 100644 > --- a/arch/arm/include/asm/pgtable.h > +++ b/arch/arm/include/asm/pgtable.h > @@ -166,6 +166,9 @@ extern struct page *empty_zero_page; > > extern pgd_t swapper_pg_dir[PTRS_PER_PGD]; > > +#define pud_page(pud) pmd_page(__pmd(pud_val(pud))) > +#define pud_write(pud) pmd_write(__pmd(pud_val(pud))) As there is no PUD, does it really make sense to return a valid struct page (which will be the PTE page) for pud_page(), which is several tables above? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!