From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8851C433E0 for ; Mon, 1 Feb 2021 22:17:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3969564D9D for ; Mon, 1 Feb 2021 22:17:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3969564D9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C07A16B0005; Mon, 1 Feb 2021 17:17:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB8D76B0006; Mon, 1 Feb 2021 17:17:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7EB86B006E; Mon, 1 Feb 2021 17:17:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 8B2336B0005 for ; Mon, 1 Feb 2021 17:17:01 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3FA661EE6 for ; Mon, 1 Feb 2021 22:17:01 +0000 (UTC) X-FDA: 77771110242.12.teeth74_4b184a5275c5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 039141801C4FB for ; Mon, 1 Feb 2021 22:17:00 +0000 (UTC) X-HE-Tag: teeth74_4b184a5275c5 X-Filterd-Recvd-Size: 6513 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 22:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612217819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xmN+agXqiROkkYz5Om/OjbH0Pxuwyb0SEcLP3k/Y+SI=; b=VsqAu0sSesPxo2FxXRQMunX7YJeMcbKX4Ozqk1gGog6dbYXqYZvg6K+oLFWh7RwL2UCkQl fxCR9zt7nZqi28ADR9Orawz2z7ScziRtKyE5RhrqDxUI4vXOmZfjvrsuzdkChCuxIbsqj4 Iw69Nmqc/rC9sFi9uwKBkbsqnkERUBk= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-82-pXnB2FsQM2mCZRNcnFqNhw-1; Mon, 01 Feb 2021 17:16:58 -0500 X-MC-Unique: pXnB2FsQM2mCZRNcnFqNhw-1 Received: by mail-qv1-f69.google.com with SMTP id n1so9570885qvi.4 for ; Mon, 01 Feb 2021 14:16:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xmN+agXqiROkkYz5Om/OjbH0Pxuwyb0SEcLP3k/Y+SI=; b=bfKGToz2z0Iozx6W7WsbL2IhNep2uOzqcWYmWn7dCBrEc5K2uSIZmYSXyH9E9MXeCn jRZ5tO7uRsR4u0P5smWlMu0GgWI6utAi9QFSdHt1lO94mYH3rr4Z1raL4wplkgRjCPmC iBGWwOB/OcTbAoIk3DlI4BmXx6HkeCZwlrR3mHVZKms29VMv7RQfu3PPriXeKfQIc1kp U9wfVmkIj8dG3G50R+xttc25cCZYdsl7R2Yt4C9zZy5TZr6k8/CdJlNGGnVERCfJJuq+ t/cSVG9aofwiUZSg2VsDTuRUhu7SdO50HEoFD5hem7vWC6R+iAqV/yGleZdRSb/oanxQ xpwQ== X-Gm-Message-State: AOAM533t+suUZoUWyTmu/lXS9+QV596joH1OOMNCSKya0tINuU226h5P OT9TsCMFQE7CRsQQQa6ODfrsKLYlDtrF1vlpupiAEOQ9Ok+Mx/NfrkqKFbf2HaXETh8bs1L/0YB yv/Insbg7btg= X-Received: by 2002:a37:8fc3:: with SMTP id r186mr18916809qkd.253.1612217817874; Mon, 01 Feb 2021 14:16:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJycp08TqePZIDEQY1l41O7S1IZiWlSToWvexBdN5xDvx00e6QmbaZ+OIJcb0uui1HUWN1gXZA== X-Received: by 2002:a37:8fc3:: with SMTP id r186mr18916780qkd.253.1612217817592; Mon, 01 Feb 2021 14:16:57 -0800 (PST) Received: from xz-x1 ([142.126.83.202]) by smtp.gmail.com with ESMTPSA id m202sm2009463qke.24.2021.02.01.14.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 14:16:56 -0800 (PST) Date: Mon, 1 Feb 2021 17:16:54 -0500 From: Peter Xu To: Mike Kravetz Cc: Axel Rasmussen , Alexander Viro , Alexey Dobriyan , Andrea Arcangeli , Andrew Morton , Anshuman Khandual , Catalin Marinas , Chinwen Chang , Huang Ying , Ingo Molnar , Jann Horn , Jerome Glisse , Lokesh Gidra , "Matthew Wilcox (Oracle)" , Michael Ellerman , Michal =?utf-8?Q?Koutn=C3=BD?= , Michel Lespinasse , Mike Rapoport , Nicholas Piggin , Shaohua Li , Shawn Anastasio , Steven Rostedt , Steven Price , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Adam Ruprecht , Cannon Matthews , "Dr . David Alan Gilbert" , David Rientjes , Oliver Upton Subject: Re: [PATCH v4 1/9] hugetlb: Pass vma into huge_pte_alloc() Message-ID: <20210201221654.GJ260413@xz-x1> References: <20210128224819.2651899-2-axelrasmussen@google.com> <20210128234242.2677079-1-axelrasmussen@google.com> <67fc15f3-3182-206b-451b-1622f6657092@oracle.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 01, 2021 at 01:53:14PM -0800, Mike Kravetz wrote: > On 2/1/21 1:38 PM, Mike Kravetz wrote: > > On 1/28/21 3:42 PM, Axel Rasmussen wrote: > >> From: Peter Xu > >> > >> It is a preparation work to be able to behave differently in the per > >> architecture huge_pte_alloc() according to different VMA attributes. > >> > >> Signed-off-by: Peter Xu > >> [axelrasmussen@google.com: fixed typo in arch/mips/mm/hugetlbpage.c] > >> Signed-off-by: Axel Rasmussen > >> --- > >> arch/arm64/mm/hugetlbpage.c | 2 +- > >> arch/ia64/mm/hugetlbpage.c | 3 ++- > >> arch/mips/mm/hugetlbpage.c | 4 ++-- > >> arch/parisc/mm/hugetlbpage.c | 2 +- > >> arch/powerpc/mm/hugetlbpage.c | 3 ++- > >> arch/s390/mm/hugetlbpage.c | 2 +- > >> arch/sh/mm/hugetlbpage.c | 2 +- > >> arch/sparc/mm/hugetlbpage.c | 2 +- > >> include/linux/hugetlb.h | 2 +- > >> mm/hugetlb.c | 6 +++--- > >> mm/userfaultfd.c | 2 +- > >> 11 files changed, 16 insertions(+), 14 deletions(-) > > > > Sorry for the delay in reviewing. > > > > huge_pmd_share() will do a find_vma() to get the vma. So, it would be > > 'possible' to not add an extra argument to huge_pmd_alloc() and simply > > do the uffd_disable_huge_pmd_share() check inside vma_shareable. This > > would reduce the amount of modified code, but would not be as efficient. > > I prefer passing the vma argument as is done here. > > > > Reviewed-by: Mike Kravetz > > > Another thought. > > We should pass the vma to huge_pmd_share to avoid the find_vma. Agreed. Seems not relevant to this series, but should be a very nice add-on after this patch can land. Thanks, -- Peter Xu