From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 061F6C433E0 for ; Tue, 2 Feb 2021 01:18:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E76064DA8 for ; Tue, 2 Feb 2021 01:18:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E76064DA8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D84766B0005; Mon, 1 Feb 2021 20:18:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0C796B0006; Mon, 1 Feb 2021 20:18:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD7516B006E; Mon, 1 Feb 2021 20:18:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id A5E306B0005 for ; Mon, 1 Feb 2021 20:18:39 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 622DA3630 for ; Tue, 2 Feb 2021 01:18:39 +0000 (UTC) X-FDA: 77771567958.03.self77_19023b7275c6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 3B05C28A4E8 for ; Tue, 2 Feb 2021 01:18:39 +0000 (UTC) X-HE-Tag: self77_19023b7275c6 X-Filterd-Recvd-Size: 2931 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 01:18:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D0A8864DD4; Tue, 2 Feb 2021 01:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612228717; bh=nubjV5RxPS9rBe0ST4Of24Ui70x9oAYNdmJ0tl2QhWI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VX5NiTQ9Jubs8sCIFZX5+4/UbBPOEWx5B+HxdzXkfH83BLJ+GDDV7Iksibf8AcKsp YfA7nFsLTTuZuK3Si2se9ublIX2GIHuhQaFxBHQXPQQ7QfAm80uvuUJgoAmb5S6UIT qfQx/CMJCrx2NKU8XM9OUfaY2v3TgsWmnM1DqRTXnyqXM7RcWfxTrWeTyaHcCakoSk bPqIsrVJ17Ex7s0pE+YPcbg7u0V9Xl6yRxHIcjI+OBMKo/BiXzFvUAuiyCt+NIrp66 TSTBCwg6hwB5pvt97bywOh1JhP2Qz8xfI2P8BR1756EcewjICgpbewLVGatX5iYTgQ LM90b6lTC+rcw== Date: Mon, 1 Feb 2021 17:18:35 -0800 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , John Hubbard , David Rientjes , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage Message-ID: <20210201171835.690558df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210131120844.7529-1-alobakin@pm.me> References: <20210131120844.7529-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 31 Jan 2021 12:11:16 +0000 Alexander Lobakin wrote: > page_is_pfmemalloc() is used mostly by networking drivers to test > if a page can be considered for reusing/recycling. > It doesn't write anything to the struct page itself, so its sole > argument can be constified, as well as the first argument of > skb_propagate_pfmemalloc(). > In Page Pool core code, it can be simply inlined instead. > Most of the callers from NIC drivers were just doppelgangers of > the same condition tests. Derive them into a new common function > do deduplicate the code. Please resend, this did not get into patchwork :/