From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782E1C433E0 for ; Mon, 1 Feb 2021 13:05:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DE53964E06 for ; Mon, 1 Feb 2021 13:05:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE53964E06 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C4D96B006C; Mon, 1 Feb 2021 08:05:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 575126B0070; Mon, 1 Feb 2021 08:05:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 462A86B0071; Mon, 1 Feb 2021 08:05:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 2ED4B6B006C for ; Mon, 1 Feb 2021 08:05:06 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E62C1181AEF1A for ; Mon, 1 Feb 2021 13:05:05 +0000 (UTC) X-FDA: 77769719370.19.gun80_5e05a9d275c2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 8EDBF1AD1AD for ; Mon, 1 Feb 2021 13:05:05 +0000 (UTC) X-HE-Tag: gun80_5e05a9d275c2 X-Filterd-Recvd-Size: 3026 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 13:05:04 +0000 (UTC) IronPort-SDR: Qp0mCDaQiYQ9KNkt+gADJYSNZf9PPPmv+8GK1tDN8eZrR0YNjHSJ9wroGSBtkY8Y4PweEd8eZd osj7jmhA5Y0g== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="159847111" X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="159847111" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 05:04:54 -0800 IronPort-SDR: AK4THoZJYK1Ba5XswMeCZXCVcRC0dQrby+5U0//H7DsBxhDH3/Tco4eNOfDNI3LjNuNy/zTBQe v0JS8fA0VJNw== X-IronPort-AV: E=Sophos;i="5.79,392,1602572400"; d="scan'208";a="355759930" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 05:04:51 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id A03A42074F; Mon, 1 Feb 2021 15:04:47 +0200 (EET) Date: Mon, 1 Feb 2021 15:04:47 +0200 From: Sakari Ailus To: Paul Kocialkowski Cc: Julia Lawall , Mauro Carvalho Chehab , linux-media@vger.kernel.org, =?iso-8859-1?Q?K=E9vin_L'h=F4pital?= , linux-kernel@vger.kernel.org, Linux Memory Management List , kbuild-all@lists.01.org Subject: Re: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings Message-ID: <20210201130447.GN32460@paasikivi.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 18, 2021 at 02:55:07PM +0100, Paul Kocialkowski wrote: > Hi, > > On Sat 16 Jan 21, 21:11, Julia Lawall wrote: > > From: kernel test robot > > > > PTR_ERR should access the value just tested by IS_ERR > > Good catch! > > Reviewed-by: Paul Kocialkowski Thanks, Julia and Paul. A patch with similar content got recently merged: commit 6e7cca2790a54057ddf64da7843271e192f71ca0 Author: Hans Verkuil Date: Wed Jan 20 09:42:38 2021 +0100 media: i2c/ov8865.c: fix error checks using wrong variable Fix two typos: dvdd -> dovdd and dvdd -> avdd Both clearly copy-and-paste mistakes. Fixes this smatch warning: drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR' Signed-off-by: Hans Verkuil Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Mauro Carvalho Chehab -- Kind regards, Sakari Ailus