From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33D9C433E0 for ; Fri, 29 Jan 2021 22:31:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F22364DE1 for ; Fri, 29 Jan 2021 22:31:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F22364DE1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1646F8D0002; Fri, 29 Jan 2021 17:31:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B9E8D0001; Fri, 29 Jan 2021 17:31:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 050A38D0002; Fri, 29 Jan 2021 17:31:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id E364C8D0001 for ; Fri, 29 Jan 2021 17:31:37 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 82F243622 for ; Fri, 29 Jan 2021 22:31:36 +0000 (UTC) X-FDA: 77760260592.20.fowl45_11172ea275ab Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 1DC6C180C0609 for ; Fri, 29 Jan 2021 22:31:36 +0000 (UTC) X-HE-Tag: fowl45_11172ea275ab X-Filterd-Recvd-Size: 4550 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 Jan 2021 22:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611959494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bkQ5Fz9RLzxxbo8DDzhzWAT6RjyUwzhlJneTB6y567o=; b=W+QCWlIslc3WFz8xBY5V0NDD88XMXMMYIaACXU1X6Lv/SY244nx4qCCpzxijnWRoLuA40o BNJMyfetiqAVTvQy09G2Cjr+JmYfdj6JAGWuAsoWTmZF9REefuFy++v1RJ/ERvrAtMzP16 Ib373xKB/lLaWStCL3mPSVFKjpE3oa0= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-3JLPuGLpO0uhW_ygtCGaTw-1; Fri, 29 Jan 2021 17:31:33 -0500 X-MC-Unique: 3JLPuGLpO0uhW_ygtCGaTw-1 Received: by mail-qt1-f197.google.com with SMTP id l15so7064422qtp.21 for ; Fri, 29 Jan 2021 14:31:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bkQ5Fz9RLzxxbo8DDzhzWAT6RjyUwzhlJneTB6y567o=; b=MPyrL5mP/Yq4uq7XznES4Qr0R9cLaR8k17Hz6idBRXKjG7swVZ/6zbWs5JQdqWK10w McWT0BNWg3/hiZDLgtUpnWrLfI+4/XxJKZZdlrODrWO8VgFrQBIPFY4MZVaEMLzMB8uh Q0+0Wr8AqJt20BLgDBtWRK/Dl88KVT5XqMxLtIw09TgQfmuQnLTtojN2j653d1vreHG+ B/Ix4SPcdfMd/ObjtySNtBtW2ZF/JexMn8x9OW6I2NyTII9Lzi2gdkGi0tzAcunKGWk5 aT7hvmIhDmCszrWhb7gczLRap0dOGw744puMnyeLmAWmi06ohSdUDDQ360rjIHTYO+B2 4RzA== X-Gm-Message-State: AOAM5320Vd3cfCr8JkFl3N4lj5z3gRsGMW00GpJmNjRts9OZ/nHEGRFF 52g+ZEtpEC21m8g4xT3OTQ0Tjb8MlM6HDPdd+4TG6VmHYY0RdcWA4VphBT+QtUpVyh8qcpw4yQy 4UWrZcRYrlAc= X-Received: by 2002:a05:622a:216:: with SMTP id b22mr6119537qtx.163.1611959492706; Fri, 29 Jan 2021 14:31:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJyf27ceBG5a1vxnJjTDK9ymzfRnbILb6rGsC4KhbZQMdfq6pGYGr2v80zPM37vNL0V1Liyd8Q== X-Received: by 2002:a05:622a:216:: with SMTP id b22mr6119516qtx.163.1611959492528; Fri, 29 Jan 2021 14:31:32 -0800 (PST) Received: from xz-x1 ([142.126.83.202]) by smtp.gmail.com with ESMTPSA id p188sm6231399qkf.40.2021.01.29.14.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 14:31:31 -0800 (PST) Date: Fri, 29 Jan 2021 17:31:29 -0500 From: Peter Xu To: Axel Rasmussen Cc: LKML , Linux MM , Mike Rapoport , Mike Kravetz , Jerome Glisse , "Kirill A . Shutemov" , Hugh Dickins , Matthew Wilcox , Andrew Morton , Andrea Arcangeli , Nadav Amit Subject: Re: [PATCH RFC 21/30] hugetlb: Pass vma into huge_pte_alloc() Message-ID: <20210129223129.GB260413@xz-x1> References: <20210115170907.24498-1-peterx@redhat.com> <20210115170907.24498-22-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 28, 2021 at 02:59:13PM -0800, Axel Rasmussen wrote: > > +pte_t *huge_pte_alloc(struct mm_struct *mm, structt vm_area_struct *vma, > > This was pointed out to me just after I sent v3 of my series today > (which includes this patch): > > Typo, s/structt/struct/. Thanks Axel - fixed here too. It's strange why it didn't complain. Re the minor fault series, I thought it would be good to have some comment from Andrea/Mike or others, but in all cases I'll read your v3 next week. (A small heads-up: you'd better use v3.1 next time for that single patch, so that just in case there will be a complete v4 series then that patch won't collapse with it) -- Peter Xu