From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC84C433E0 for ; Wed, 27 Jan 2021 23:04:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3280464DCC for ; Wed, 27 Jan 2021 23:04:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3280464DCC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BCB66B0005; Wed, 27 Jan 2021 18:04:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81F256B0006; Wed, 27 Jan 2021 18:04:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C09D6B006E; Wed, 27 Jan 2021 18:04:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 4FD236B0005 for ; Wed, 27 Jan 2021 18:04:25 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1371E181AEF30 for ; Wed, 27 Jan 2021 23:04:25 +0000 (UTC) X-FDA: 77753085690.30.mass24_2a1792e2759a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id DC782180B3C83 for ; Wed, 27 Jan 2021 23:04:24 +0000 (UTC) X-HE-Tag: mass24_2a1792e2759a X-Filterd-Recvd-Size: 3373 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 23:04:24 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A84E64DCE; Wed, 27 Jan 2021 23:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611788661; bh=3Jk8U/JdRNH+EkcfRbQkniS/eY1h1c1PGw5876r0Qeo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Or6G1XJCcSY0tUxiG7eWRkWxY1zu10ldDMd2CaVn53QLTsg/SwbcQyI1MDpuviHEA 5bNiuF9k8OvH/fuA8Tlluiuc2oUOLR3UlbehfATDgAHWmrJOjHdQp8HlHff9b7ASz+ s4+1vB7kRlylHeB7D6Y8fQVMAOW/ooLYkq7gFQarXqrtucnWcXCK5/q33yHVLkq9n3 f45VGFywiax2CWgR0LOB9XQByXD/OasiIuAgI2RLzcbz9qRpOa3kN+AUPs4uNLa9QD rPIM5KMKR+gHpL2qXG5Z0l+emdbACmeH11j/73u6/Y9936Na0Z52d9P4WtiHgM1f2I rhQdgxwfZu14A== Date: Wed, 27 Jan 2021 23:04:14 +0000 From: Will Deacon To: Lecopzer Chen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, dan.j.williams@intel.com, aryabinin@virtuozzo.com, glider@google.com, dvyukov@google.com, akpm@linux-foundation.org, linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com, catalin.marinas@arm.com, ardb@kernel.org, andreyknvl@google.com, broonie@kernel.org, linux@roeck-us.net, rppt@kernel.org, tyhicks@linux.microsoft.com, robin.murphy@arm.com, vincenzo.frascino@arm.com, gustavoars@kernel.org, Lecopzer Chen Subject: Re: [PATCH v2 4/4] arm64: kaslr: support randomized module area with KASAN_VMALLOC Message-ID: <20210127230413.GA1016@willie-the-truck> References: <20210109103252.812517-1-lecopzer@gmail.com> <20210109103252.812517-5-lecopzer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210109103252.812517-5-lecopzer@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 09, 2021 at 06:32:52PM +0800, Lecopzer Chen wrote: > After KASAN_VMALLOC works in arm64, we can randomize module region > into vmalloc area now. > > Test: > VMALLOC area ffffffc010000000 fffffffdf0000000 > > before the patch: > module_alloc_base/end ffffffc008b80000 ffffffc010000000 > after the patch: > module_alloc_base/end ffffffdcf4bed000 ffffffc010000000 > > And the function that insmod some modules is fine. > > Suggested-by: Ard Biesheuvel > Signed-off-by: Lecopzer Chen > --- > arch/arm64/kernel/kaslr.c | 18 ++++++++++-------- > arch/arm64/kernel/module.c | 16 +++++++++------- > 2 files changed, 19 insertions(+), 15 deletions(-) > > diff --git a/arch/arm64/kernel/kaslr.c b/arch/arm64/kernel/kaslr.c > index 1c74c45b9494..a2858058e724 100644 > --- a/arch/arm64/kernel/kaslr.c > +++ b/arch/arm64/kernel/kaslr.c > @@ -161,15 +161,17 @@ u64 __init kaslr_early_init(u64 dt_phys) > /* use the top 16 bits to randomize the linear region */ > memstart_offset_seed = seed >> 48; > > - if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > - IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > + if (!IS_ENABLED(CONFIG_KASAN_VMALLOC) && > + (IS_ENABLED(CONFIG_KASAN_GENERIC) || CONFIG_KASAN_VMALLOC depends on CONFIG_KASAN_GENERIC so why is this necessary? Will