From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E5FC433E0 for ; Wed, 27 Jan 2021 18:27:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7E5F764DA5 for ; Wed, 27 Jan 2021 18:27:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E5F764DA5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74FA36B006C; Wed, 27 Jan 2021 13:27:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FFE96B006E; Wed, 27 Jan 2021 13:27:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EF5E6B0070; Wed, 27 Jan 2021 13:27:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 47C246B006C for ; Wed, 27 Jan 2021 13:27:10 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0EF2C1EF2 for ; Wed, 27 Jan 2021 18:27:10 +0000 (UTC) X-FDA: 77752387020.16.blade42_440062827599 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id D0857100E6912 for ; Wed, 27 Jan 2021 18:27:09 +0000 (UTC) X-HE-Tag: blade42_440062827599 X-Filterd-Recvd-Size: 10445 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 18:27:08 +0000 (UTC) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10RIHDCI036792; Wed, 27 Jan 2021 13:27:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=pp1; bh=Cs7vVcVEinjdu3nzZ3wIpq6Kuaavfjxy7BT5QDRN1K4=; b=J0MhQnoZR5MlkQZVKI8K7JsaVnUdbxSuzYIHqt0BXQPgZfMiC3iLal+me9qFC2gddfb4 fTwJjqBqhO9MWVy/fAR7h+8BfzhFlM/g5rClB1Yr/cizmXzNC2aeWU90DUd7Z5fLxTj7 QFcx0bGMmHQe+CE3Rq2PuQQ3fU1zCEcTtYBbZb8jWlK23wNn0pH67TEQGWnR5ws1qWYa yUlFv/QXR7yqHGRaWj63/6/oiughR4w3ocRxvcjqMGOiWxkCMO3CAwBk6HFROZmwtLW5 k7NtIlhEkXjktJaG3h95WazALLoRWpwabLeTlN9rEyM/4vt6fw4Uuir9tWdAijtNuwO3 sw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 36b5awe549-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jan 2021 13:27:02 -0500 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 10RIHJV3037717; Wed, 27 Jan 2021 13:27:01 -0500 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 36b5awe53s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jan 2021 13:27:01 -0500 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10RII4qs001584; Wed, 27 Jan 2021 18:26:59 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03ams.nl.ibm.com with ESMTP id 368be7v309-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Jan 2021 18:26:59 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10RIQvmM39584002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Jan 2021 18:26:57 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 707EDA4060; Wed, 27 Jan 2021 18:26:57 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C16DEA405B; Wed, 27 Jan 2021 18:26:54 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.191.214]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 27 Jan 2021 18:26:54 +0000 (GMT) Date: Wed, 27 Jan 2021 20:26:51 +0200 From: Mike Rapoport To: =?utf-8?Q?=C5=81ukasz?= Majczak Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, =?utf-8?B?UmFkb3PFgmF3?= Biernacki , Marcin Wojtas , Alex Levin , Guenter Roeck , Jesse Barnes , Chris Wilson , "Sarvela, Tomi P" Subject: Re: PROBLEM: Crash after mm: fix initialization of struct page for holes in memory layout Message-ID: <20210127182651.GA281042@linux.ibm.com> References: <20210127100454.GK196782@linux.ibm.com> <20210127111858.GA273567@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2021-01-27_06:2021-01-27,2021-01-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101270088 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Lukasz, On Wed, Jan 27, 2021 at 02:15:53PM +0100, =C5=81ukasz Majczak wrote: > Hi Mike, >=20 > I have started bisecting your patch and I have figured out that there > might be something wrong with clamping - with comments out these lines > it started to work. > The full log (with logs from below patch) can be found here: > https://gist.github.com/semihalf-majczak-lukasz/3cecbab0ddc59a6c3ce11dd= c29645725 > it's fresh - I haven't analyze it yet, just sharing with hope it will h= elp. Thanks, that helps! The first page is never considered by the kernel as memory and so arch_zone_lowest_possible_pfn[ZONE_DMA] is set to 0x1000. As the result, init_unavailable_mem() skips pfn 0 and then __SetPageReserved(page) in reserve_bootmem_region() panics because the struct page for pfn 0 remains poisoned. Can you please try the below patch on top of v5.11-rc5? diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 783913e41f65..3ce9ef238dfc 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7083,10 +7083,11 @@ void __init free_area_init_memoryless_node(int ni= d) static u64 __init init_unavailable_range(unsigned long spfn, unsigned lo= ng epfn, int zone, int nid) { - unsigned long pfn, zone_spfn, zone_epfn; + unsigned long pfn, zone_spfn =3D 0, zone_epfn; u64 pgcnt =3D 0; =20 - zone_spfn =3D arch_zone_lowest_possible_pfn[zone]; + if (zone > 0) + zone_spfn =3D arch_zone_highest_possible_pfn[zone - 1]; zone_epfn =3D arch_zone_highest_possible_pfn[zone]; =20 spfn =3D clamp(spfn, zone_spfn, zone_epfn); =20 > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index eed54ce26ad1..9f4468c413a1 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7093,9 +7093,11 @@ static u64 __init > init_unavailable_range(unsigned long spfn, unsigned long epfn, > zone_spfn =3D arch_zone_lowest_possible_pfn[zone]; > zone_epfn =3D arch_zone_highest_possible_pfn[zone]; >=20 > - spfn =3D clamp(spfn, zone_spfn, zone_epfn); > - epfn =3D clamp(epfn, zone_spfn, zone_epfn); > - > + //spfn =3D clamp(spfn, zone_spfn, zone_epfn); > + //epfn =3D clamp(epfn, zone_spfn, zone_epfn); > + pr_info("LMA DBG: zone_spfn: %llx, zone_epfn %llx\n", > zone_spfn, zone_epfn); > + pr_info("LMA DBG: spfn: %llx, epfn %llx\n", spfn, epfn); > + pr_info("LMA DBG: clamp_spfn: %llx, clamp_epfn %llx\n", > clamp(spfn, zone_spfn, zone_epfn), clamp(epfn, zone_spfn, zone_epfn)); > for (pfn =3D spfn; pfn < epfn; pfn++) { > if (!pfn_valid(ALIGN_DOWN(pfn, pageblock_nr_pages))) { > pfn =3D ALIGN_DOWN(pfn, pageblock_nr_pages) >=20 > Best regards, > Lukasz >=20 >=20 > =C5=9Br., 27 sty 2021 o 13:15 =C5=81ukasz Majczak na= pisa=C5=82(a): > > > > Unfortunately nothing :( my current kernel command line contains: > > console=3DttyS0,115200n8 debug earlyprintk=3Dserial loglevel=3D7 > > > > I was thinking about using earlycon, but it seems to be blocked. > > (I think the lack of earlycon might be related to Chromebook HW > > security design. There is an EC controller which is a part of AP -> > > serial chain as kernel messages are considered sensitive from a > > security standpoint.) > > > > Best regards, > > Lukasz > > > > =C5=9Br., 27 sty 2021 o 12:19 Mike Rapoport napi= sa=C5=82(a): > > > > > > On Wed, Jan 27, 2021 at 11:08:17AM +0100, =C5=81ukasz Majczak wrote= : > > > > Hi Mike, > > > > > > > > Actually I have a serial console attached (via servo device), but > > > > there is no output :( and also the reboot/crash is very fast/imme= diate > > > > after power on. > > > > > > If you boot with earlyprintk=3Dserial are there any messages? > > > > > > > Best regards > > > > Lukasz > > > > > > > > =C5=9Br., 27 sty 2021 o 11:05 Mike Rapoport = napisa=C5=82(a): > > > > > > > > > > Hi Lukasz, > > > > > > > > > > On Wed, Jan 27, 2021 at 10:22:29AM +0100, =C5=81ukasz Majczak w= rote: > > > > > > Crash after mm: fix initialization of struct page for holes i= n memory layout > > > > > > > > > > > > Hi, > > > > > > I was trying to run v5.11-rc5 on my Samsung Chromebook Pro (C= aroline), > > > > > > but I've noticed it has crashed - unfortunately it seems to h= appen at > > > > > > a very early stage - No output to the console nor to the scre= en, so I > > > > > > have started a bisect (between 5.11-rc4 - which works just fi= nd - and > > > > > > 5.11-rc5), > > > > > > bisect results points to: > > > > > > > > > > > > d3921cb8be29 mm: fix initialization of struct page for holes = in memory layout > > > > > > > > > > > > Reproduction is just to build and load the kernel. > > > > > > > > > > > > If it will help any how I am attaching: > > > > > > - /proc/cpuinfo (from healthy system): > > > > > > https://gist.github.com/semihalf-majczak-lukasz/3517867bf39f0= 7377c1a785b64a97066 > > > > > > - my .config file (for a broken system): > > > > > > https://gist.github.com/semihalf-majczak-lukasz/584b329f1bf3e= 43b53efe8e18b5da33c > > > > > > > > > > > > If there is anything I could add/do/test to help fix this ple= ase let me know. > > > > > > > > > > Chris Wilson also reported boot failures on several Chromebooks= : > > > > > > > > > > https://lore.kernel.org/lkml/161160687463.28991.354987542182281= 928@build.alporthouse.com > > > > > > > > > > I presume serial console is not an option, so if you could boot= with > > > > > earlyprintk=3Dvga and see if there is anything useful printed o= n the screen > > > > > it would be really helpful. > > > > > > > > > > > Best regards > > > > > > Lukasz > > > > > > > > > > -- > > > > > Sincerely yours, > > > > > Mike. > > > > > > -- > > > Sincerely yours, > > > Mike. --=20 Sincerely yours, Mike.