From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1526EC433E0 for ; Wed, 27 Jan 2021 21:52:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D64C64DA3 for ; Wed, 27 Jan 2021 21:52:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D64C64DA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CAE4E6B0006; Wed, 27 Jan 2021 16:52:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C647F6B006E; Wed, 27 Jan 2021 16:52:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90A666B0070; Wed, 27 Jan 2021 16:52:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id 73BCA6B0006 for ; Wed, 27 Jan 2021 16:52:22 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3D13D1EE6 for ; Wed, 27 Jan 2021 21:52:22 +0000 (UTC) X-FDA: 77752904124.26.knot62_28139842759a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id E98FF1804B660 for ; Wed, 27 Jan 2021 21:52:21 +0000 (UTC) X-HE-Tag: knot62_28139842759a X-Filterd-Recvd-Size: 3051 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 21:52:20 +0000 (UTC) IronPort-SDR: pSdIbPRSw2MY/dTEWFUh7H8UNgfzkXw4Dx6qc14IQO7pSxdINCoDoxL3EwdAkGvsP1LiMOzFw0 3QR1pgwq3YDw== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="179357160" X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="179357160" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 13:52:15 -0800 IronPort-SDR: eMUsAMTAn1/kJKi2+N3WYkgp2WWjSfrhNUEGMZw4T01LBxqqkukZ/UCturgutvXJEvoRl1ZhpB h4jTZtxahTwA== X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="573410519" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.44.59]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 13:52:13 -0800 Date: Wed, 27 Jan 2021 13:52:11 -0800 From: Jesse Brandeburg To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , David Rientjes , Yisen Zhuang , Salil Mehta , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage Message-ID: <20210127135211.00005620@intel.com> In-Reply-To: <20210127201031.98544-1-alobakin@pm.me> References: <20210127201031.98544-1-alobakin@pm.me> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Alexander Lobakin wrote: > page_is_pfmemalloc() is used mostly by networking drivers to test > if a page can be considered for reusing/recycling. > It doesn't write anything to the struct page itself, so its sole > argument can be constified, as well as the first argument of > skb_propagate_pfmemalloc(). > In Page Pool core code, it can be simply inlined instead. > Most of the callers from NIC drivers were just doppelgangers of > the same condition tests. Derive them into a new common function > do deduplicate the code. This is a useful cleanup! Thanks. For the series: Reviewed-by: Jesse Brandeburg