From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/vmemmap: Handle unpopulated sub-pmd ranges
Date: Wed, 27 Jan 2021 12:34:41 +0100 [thread overview]
Message-ID: <20210127113436.GA28551@linux> (raw)
In-Reply-To: <ff7c0838-bfb2-9904-8dcc-4f6f979734d3@redhat.com>
On Wed, Jan 27, 2021 at 12:29:27PM +0100, David Hildenbrand wrote:
> > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> > index b5a3fa4033d3..9b6d45ea353b 100644
> > --- a/arch/x86/mm/init_64.c
> > +++ b/arch/x86/mm/init_64.c
> > @@ -873,6 +873,71 @@ int arch_add_memory(int nid, u64 start, u64 size,
> > #define PAGE_INUSE 0xFD
>
> Note that I called it "PAGE_UNUSED", using "PAGE_INUSE" might make it a
> little harder to digest.
Yeah, I wanted to recycle the PAGE_INUSE macro for x86, but on a second though
we might just call it PAGE_UNUSE as it gives a better perspective.
Let us see if there are other pushbacks/reviews, and if not, I shall re-submit
with that addressed.
Thanks
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2021-01-27 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 11:23 Oscar Salvador
2021-01-27 11:29 ` David Hildenbrand
2021-01-27 11:34 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127113436.GA28551@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox